Bugzilla – Attachment 157593 Details for
Bug 35124
Incorrect item groups table markup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35124: Incorrect item groups table markup
Bug-35124-Incorrect-item-groups-table-markup.patch (text/plain), 1.83 KB, created by
Katrin Fischer
on 2023-10-21 08:44:43 UTC
(
hide
)
Description:
Bug 35124: Incorrect item groups table markup
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-21 08:44:43 UTC
Size:
1.83 KB
patch
obsolete
>From c5c43ead404820ba34f6f76620dd2182e0ee8f04 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 20 Oct 2023 17:01:00 +0000 >Subject: [PATCH] Bug 35124: Incorrect item groups table markup > >This patch corrects the markup of the item groups table which is found >under the "Item groups" tab on the bibliographip detail page in the >staff interface. > >The patch also adds the "NoSort" class to the "actions" column to >prevent it from being sortable. > >To test, apply the patch and make sure the "EnableItemGroups" system >preference is enabled. > >- In the staff interface, locate a record with items and view the detail > page. >- Under the "Item groups" tab confirm that the table looks correct: The > heading labels should be centered bold text. >- You should see sorting indicators on the "Display order" and "Description" > headings but not on the last one. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index a3c08aa693..562532a27a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -673,9 +673,9 @@ > <table class="items-group-table" id="items-group-table"> > <thead> > <tr> >- <td>Display order</td> >- <td>Description</td> >- <td> </td> >+ <th>Display order</th> >+ <th>Description</th> >+ <th class="NoSort"> </th> > </tr> > </thead> > </table> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35124
:
157558
|
157581
| 157593