Attachment 157781 Details for Bug 31503 – Bug 31503: (QA follow-up) Improve count of available_types

[patch] Bug 31503: (QA follow-up) Improve count of available_types

Bug-31503-QA-follow-up-Improve-count-of-availablet.patch (text/plain), 1.48 KB, created by Marcel de Rooy on 2023-10-25 11:32:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-25 11:32:26 UTC

Size: 1.48 KB

patch

obsolete

>From 0c38ca1b49cf85f5f992925bedf73c44c475b5ad Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 13 Oct 2023 14:54:47 +0000
>Subject: [PATCH] Bug 31503: (QA follow-up) Improve count of available_types
>Content-Type: text/plain; charset=utf-8
>
>Tidied one other line.
>
>Test plan:
>Run t/db_dependent/Koha/Patron/Consents.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Patron/Consents.t | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patron/Consents.t b/t/db_dependent/Koha/Patron/Consents.t
>index eeea426ab3..5120022797 100755
>--- a/t/db_dependent/Koha/Patron/Consents.t
>+++ b/t/db_dependent/Koha/Patron/Consents.t
>@@ -54,9 +54,12 @@ subtest 'Method available_types' => sub {
>     plan tests => 7;
>     $schema->storage->txn_begin;
> 
>-    t::lib::Mocks::mock_preference( 'PrivacyPolicyConsent',   'Enforced' );
>-    my $types = Koha::Patron::Consents->available_types;
>-    is( keys %$types, 1, 'Expect one type for privacy policy' );
>+    t::lib::Mocks::mock_preference( 'PrivacyPolicyConsent', q{} );
>+    my $types        = Koha::Patron::Consents->available_types;
>+    my $count_before = scalar keys %$types;
>+    t::lib::Mocks::mock_preference( 'PrivacyPolicyConsent', 'Enforced' );
>+    $types = Koha::Patron::Consents->available_types;
>+    is( keys %$types, $count_before + 1, 'Expect one type more for privacy policy' );
> 
>     # Mock get_enabled_plugins
>     my $plugins        = [];
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31503: 140047 | 140048 | 140049 | 140050 | 140080 | 140081 | 140082 | 140083 | 140084 | 140085 | 140087 | 140088 | 140089 | 140090 | 140666 | 140667 | 140668 | 140669 | 140670 | 140671 | 140672 | 141216 | 141217 | 141218 | 141219 | 141220 | 141221 | 141222 | 141263 | 141264 | 141265 | 141266 | 141267 | 141268 | 141269 | 141302 | 141570 | 155000 | 155001 | 155002 | 155003 | 155177 | 155178 | 155179 | 155180 | 155189 | 155190 | 155191 | 155656 | 155657 | 155658 | 155659 | 155660 | 155661 | 155691 | 155694 | 155783 | 155784 | 155785 | 155786 | 155787 | 155788 | 155789 | 155790 | 155791 | 157117 | 157118 | 157119 | 157120 | 157121 | 157122 | 157123 | 157124 | 157125 | 157126 | 157773 | 157774 | 157775 | 157776 | 157777 | 157778 | 157779 | 157780 | 157781 | 157782 | 157783