Bugzilla – Attachment 157785 Details for
Bug 33169
Improve vue breadcrumbs and left-hand menu
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[23.05] Bug 33169: (QA follow-up) Fix some icons for lower FA version
2305-Bug-33169-QA-follow-up-Fix-some-icons-for-low.patch (text/plain), 16.44 KB, created by
Katrin Fischer
on 2023-10-25 11:51:49 UTC
(
hide
)
Description:
[23.05] Bug 33169: (QA follow-up) Fix some icons for lower FA version
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-25 11:51:49 UTC
Size:
16.44 KB
patch
obsolete
>From 9e1a9e2e358b5674df74b0bfbeca86abaa017bda Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Wed, 25 Oct 2023 11:38:27 +0000 >Subject: [PATCH] [23.05] Bug 33169: (QA follow-up) Fix some icons for lower FA > version > >In the navigation some icons were missing, because they had changed >names between versions, this restores them. Fixed icons concerned >the navigation items: > >* Local >* Local > Titles >* EBSCO > Titles >--- > .../intranet-tmpl/prog/js/vue/routes/erm.js | 123 ++++++++++++------ > 1 file changed, 86 insertions(+), 37 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >index c416ca0353b..0454f6fed47 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >@@ -37,7 +37,7 @@ export const routes = [ > path: "/cgi-bin/koha/erm/erm.pl", > is_default: true, > is_base: true, >- title: { dynamic: false, text: $__("E-resource management")}, >+ title: { dynamic: false, text: $__("E-resource management") }, > children: [ > { > path: "", >@@ -47,7 +47,7 @@ export const routes = [ > }, > { > path: "/cgi-bin/koha/erm/agreements", >- title: { dynamic: false, text: $__("Agreements")}, >+ title: { dynamic: false, text: $__("Agreements") }, > icon: "fa fa-check-circle", > is_end_node: true, > children: [ >@@ -60,45 +60,55 @@ export const routes = [ > path: ":agreement_id", > name: "AgreementsShow", > component: markRaw(AgreementsShow), >- title: { dynamic: true, text: $__("Show agreement")}, >+ title: { dynamic: true, text: $__("Show agreement") }, > children: [ > { > path: "items", >- title: { dynamic: false, text: $__("")}, >+ title: { dynamic: false, text: $__("") }, > children: [ > { > path: "add", > name: "TestChildTwo", >- component: markRaw(EHoldingsLocalTitlesFormAdd), >- title: { dynamic: false, text: $__("Add item to train")}, >+ component: markRaw( >+ EHoldingsLocalTitlesFormAdd >+ ), >+ title: { >+ dynamic: false, >+ text: $__("Add item to train"), >+ }, > }, > { > path: "add/:item_ids", > name: "TestChildThree", >- component: markRaw(EHoldingsLocalPackagesFormAdd), >- title: { dynamic: false, text: $__("Add items to train")}, >+ component: markRaw( >+ EHoldingsLocalPackagesFormAdd >+ ), >+ title: { >+ dynamic: false, >+ text: $__("Add items to train"), >+ }, > }, >- ] >+ ], > }, >- ] >+ ], > }, > { > path: "add", > name: "AgreementsFormAdd", > component: markRaw(AgreementsFormAdd), >- title: { dynamic: false, text: $__("Add agreement")}, >+ title: { dynamic: false, text: $__("Add agreement") }, > }, > { > path: "edit/:agreement_id", > name: "AgreementsFormAddEdit", > component: markRaw(AgreementsFormAdd), >- title: { dynamic: true, text: $__("Edit agreement")}, >+ title: { dynamic: true, text: $__("Edit agreement") }, > }, > ], > }, > { > path: "/cgi-bin/koha/erm/licenses", >- title: { dynamic: false, text: $__("Licenses")}, >+ title: { dynamic: false, text: $__("Licenses") }, > icon: "fa fa-gavel", > is_end_node: true, > children: [ >@@ -111,37 +121,40 @@ export const routes = [ > path: ":license_id", > name: "LicensesShow", > component: markRaw(LicensesShow), >- title: { dynamic: true, text: $__("Show license")} >+ title: { dynamic: true, text: $__("Show license") }, > }, > { > path: "add", > name: "LicensesFormAdd", > component: markRaw(LicensesFormAdd), >- title: { dynamic: false, text: $__("Add license")} >+ title: { dynamic: false, text: $__("Add license") }, > }, > { > path: "edit/:license_id", > name: "LicensesFormAddEdit", > component: markRaw(LicensesFormAdd), >- title: { dynamic: true, text: $__("Edit license")} >+ title: { dynamic: true, text: $__("Edit license") }, > }, > ], > }, > { > path: "/cgi-bin/koha/erm/eholdings", >- title: { dynamic: false, text: $__("eHoldings")}, >+ title: { dynamic: false, text: $__("eHoldings") }, > icon: "fa fa-crosshairs", > disabled: true, > children: [ > { > path: "local", >- title: { dynamic: false, text: $__("Local")}, >- icon: "fa-solid fa-location-dot", >+ title: { dynamic: false, text: $__("Local") }, >+ icon: "fa fa-map-marker", > disabled: true, > children: [ > { > path: "packages", >- title: { dynamic: false, text: $__("Packages")}, >+ title: { >+ dynamic: false, >+ text: $__("Packages"), >+ }, > icon: "fa fa-archive", > is_end_node: true, > children: [ >@@ -158,7 +171,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalPackagesShow > ), >- title: { dynamic: true, text: $__("Show package")} >+ title: { >+ dynamic: true, >+ text: $__("Show package"), >+ }, > }, > { > path: "add", >@@ -166,7 +182,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalPackagesFormAdd > ), >- title: { dynamic: false, text: $__("Add package")} >+ title: { >+ dynamic: false, >+ text: $__("Add package"), >+ }, > }, > { > path: "edit/:package_id", >@@ -174,14 +193,17 @@ export const routes = [ > component: markRaw( > EHoldingsLocalPackagesFormAdd > ), >- title: { dynamic: true, text: $__("Edit package")} >+ title: { >+ dynamic: true, >+ text: $__("Edit package"), >+ }, > }, > ], > }, > { > path: "titles", >- title: { dynamic: false, text: $__("Titles")}, >- icon: "fa-solid fa-arrow-down-a-z", >+ title: { dynamic: false, text: $__("Titles") }, >+ icon: "fa fa-sort-alpha-asc", > is_end_node: true, > children: [ > { >@@ -197,7 +219,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalTitlesShow > ), >- title: { dynamic: true, text: $__("Show title")} >+ title: { >+ dynamic: true, >+ text: $__("Show title"), >+ }, > }, > { > path: "add", >@@ -205,7 +230,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalTitlesFormAdd > ), >- title: { dynamic: false, text: $__("Add title")} >+ title: { >+ dynamic: false, >+ text: $__("Add title"), >+ }, > }, > { > path: "edit/:title_id", >@@ -213,7 +241,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalTitlesFormAdd > ), >- title: { dynamic: true, text: $__("Edit title")} >+ title: { >+ dynamic: true, >+ text: $__("Edit title"), >+ }, > }, > { > path: "import", >@@ -221,7 +252,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalTitlesFormImport > ), >- title: { dynamic: false, text: $__("Import from a list")} >+ title: { >+ dynamic: false, >+ text: $__("Import from a list"), >+ }, > }, > { > path: "/cgi-bin/koha/erm/eholdings/local/resources/:resource_id", >@@ -229,7 +263,10 @@ export const routes = [ > component: markRaw( > EHoldingsLocalResourcesShow > ), >- title: { dynamic: true, text: $__("Resource")} >+ title: { >+ dynamic: true, >+ text: $__("Resource"), >+ }, > }, > ], > }, >@@ -237,13 +274,16 @@ export const routes = [ > }, > { > path: "ebsco", >- title: { dynamic: false, text: $__("EBSCO")}, >+ title: { dynamic: false, text: $__("EBSCO") }, > icon: "fa fa-globe", > disabled: true, > children: [ > { > path: "packages", >- title: { dynamic: false, text: $__("Packages")}, >+ title: { >+ dynamic: false, >+ text: $__("Packages"), >+ }, > icon: "fa fa-archive", > is_end_node: true, > children: [ >@@ -260,14 +300,17 @@ export const routes = [ > component: markRaw( > EHoldingsEBSCOPackagesShow > ), >- title: { dynamic: true, text: $__("Show package")} >+ title: { >+ dynamic: true, >+ text: $__("Show package"), >+ }, > }, > ], > }, > { > path: "titles", >- title: { dynamic: true, text: $__("Titles")}, >- icon: "fa-solid fa-arrow-down-a-z", >+ title: { dynamic: true, text: $__("Titles") }, >+ icon: "fa fa-sort-alpha-asc", > is_end_node: true, > children: [ > { >@@ -283,7 +326,10 @@ export const routes = [ > component: markRaw( > EHoldingsEBSCOTitlesShow > ), >- title: { dynamic: true, text: $__("Show title")} >+ title: { >+ dynamic: true, >+ text: $__("Show title"), >+ }, > }, > { > path: "/cgi-bin/koha/erm/eholdings/ebsco/resources/:resource_id", >@@ -291,7 +337,10 @@ export const routes = [ > component: markRaw( > EHoldingsEBSCOResourcesShow > ), >- title: { dynamic: true, text: $__("Resource")}, >+ title: { >+ dynamic: true, >+ text: $__("Resource"), >+ }, > is_navigation_item: false, > }, > ], >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33169
:
147962
|
148044
|
148081
|
148097
|
149710
|
149744
|
151530
|
151797
|
152068
|
152539
|
152540
|
152541
|
153889
|
153890
| 157785 |
157806
|
157807