Attachment 157848 Details for Bug 25672 – Bug 25672: (QA follow-up) Hide install after search button

[patch] Bug 25672: (QA follow-up) Hide install after search button

Bug-25672-QA-follow-up-Hide-install-after-search-b.patch (text/plain), 2.51 KB, created by Victor Grousset/tuxayo on 2023-10-25 16:35:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2023-10-25 16:35:11 UTC

Size: 2.51 KB

patch

obsolete

>From b304eed472cf3ba8ab63bbb703b76c95dbc54838 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 22 Jul 2020 09:10:29 +0100
>Subject: [PATCH] Bug 25672: (QA follow-up) Hide install after search button
>
>If plugin upload is disabled, but there are git repositories listed in
>the config for plugin searching, then you can search for a plugin and
>attempt to install it. The install leads to an error page.
>
>This patch removes the actions column and install button should the
>enable_browser_upload option be disabled
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/plugins/plugins-home.tt     | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
>index 98f71298a3..aefd39d1e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
>@@ -90,7 +90,9 @@
>                                         <th>Description</th>
>                                         <th>Organization</th>
>                                         <th>Latest version</th>
>+                                        [% IF ( enable_browser_upload ) %]
>                                         <th>&nbsp;</th>
>+                                        [% END %]
>                                     </tr>
>                                 </thead>
> 
>@@ -100,7 +102,9 @@
>                                         <td>[% sr.result.description | html %]</td>
>                                         <td>[% sr.repo.name | html %]</td>
>                                         <td>[% sr.result.tag_name | html %]</td>
>+                                        [% IF ( enable_browser_upload ) %]
>                                         <td><a class="btn btn-default btn-sm btn-install-plugin" href="/cgi-bin/koha/plugins/plugins-upload.pl?op=Upload&uploadfile=[% sr.result.install_name | uri %]&uploadlocation=[% sr.result.install_url | uri %]"><i class="fa fa-download"></i> Install</a></td>
>+                                        [% END %]
>                                     </tr>
>                                 [% END %]
>                             </table>
>-- 
>2.42.0

Actions: View | Diff | Splinter Review

Attachments on bug 25672: 106651 | 106671 | 106673 | 106674 | 107172 | 107173 | 107174 | 153824 | 153825 | 153826 | 153827 | 153925 | 154423 | 154424 | 154425 | 154426 | 154427 | 154453 | 154455 | 154464 | 154465 | 154466 | 154467 | 154468 | 154474 | 154475 | 154476 | 154477 | 154478 | 156715 | 156716 | 156717 | 156718 | 156719 | 156720 | 156734 | 156735 | 156736 | 156737 | 156738 | 156739 | 156740 | 157730 | 157810 | 157811 | 157812 | 157813 | 157814 | 157815 | 157816 | 157817 | 157836 | 157837 | 157838 | 157839 | 157840 | 157841 | 157842 | 157843 | 157846 | 157847 | 157848 | 157849 | 157850 | 157851 | 157852 | 157853