Bugzilla – Attachment 15787 Details for
Bug 8917
Track clicks to links external to Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs
Bug-8917--Fixing-a-bug-bgkriegel-spotted-and-remov.patch (text/plain), 2.69 KB, created by
Chris Cormack
on 2013-02-28 18:57:19 UTC
(
hide
)
Description:
Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-02-28 18:57:19 UTC
Size:
2.69 KB
patch
obsolete
>From 73384fdad40e1cb6baeeb2bc4d71a541d4f5d496 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 27 Feb 2013 09:32:24 +1300 >Subject: [PATCH] Bug 8917 : Fixing a bug bgkriegel spotted and removing tabs > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >--- > installer/data/mysql/updatedatabase.pl | 37 +++++++++++++++++--------------- > opac/tracklinks.pl | 2 +- > 2 files changed, 21 insertions(+), 18 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index c92778a..04a4f6f 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6439,24 +6439,27 @@ if ( CheckVersion($DBversion) ) { > > $DBversion = "3.11.00.XXX"; > if ( CheckVersion($DBversion) ) { >- $dbh->do("CREATE TABLE linktracker ( >- id int(11) NOT NULL AUTO_INCREMENT, >- biblionumber int(11) DEFAULT NULL, >- itemnumber int(11) DEFAULT NULL, >- borrowernumber int(11) DEFAULT NULL, >- url text, >- timeclicked datetime DEFAULT NULL, >- PRIMARY KEY (id), >- KEY bibidx (biblionumber), >- KEY itemidx (itemnumber), >- KEY borridx (borrowernumber), >- KEY dateidx (timeclicked) >- ) ENGINE=InnoDB DEFAULT CHARSET=utf8;"); >- $dbh->do(" >+ $dbh->do( >+ "CREATE TABLE linktracker ( >+ id int(11) NOT NULL AUTO_INCREMENT, >+ biblionumber int(11) DEFAULT NULL, >+ itemnumber int(11) DEFAULT NULL, >+ borrowernumber int(11) DEFAULT NULL, >+ url text, >+ timeclicked datetime DEFAULT NULL, >+ PRIMARY KEY (id), >+ KEY bibidx (biblionumber), >+ KEY itemidx (itemnumber), >+ KEY borridx (borrowernumber), >+ KEY dateidx (timeclicked) >+ ) ENGINE=InnoDB DEFAULT CHARSET=utf8;" >+ ); >+ $dbh->do( " > INSERT INTO systempreferences (variable,value,explanation,options,type) >- VALUES('TrackClicks','0','Track links clicked',NULL,'Integer')"); >- print "Upgrade to $DBversion done (Adds feature Bug 8917, the ability to track links clicked)"; >- SetVersion ($DBversion); >+ VALUES('TrackClicks','0','Track links clicked',NULL,'Integer')" ); >+ print >+"Upgrade to $DBversion done (Adds feature Bug 8917, the ability to track links clicked)"; >+ SetVersion($DBversion); > } > > =head1 FUNCTIONS >diff --git a/opac/tracklinks.pl b/opac/tracklinks.pl >index cc1d5e3..5c07cdd 100755 >--- a/opac/tracklinks.pl >+++ b/opac/tracklinks.pl >@@ -35,7 +35,7 @@ if ($uri) { > # we have a uri and we want to track > if ( $trackinglinks eq 'track' ) { > my ( $user, $cookie, $sessionID, $flags ) = >- checkauth( $cgi, 1, '', 'opac' ); >+ checkauth( $cgi, 1, {}, 'opac' ); > my $userenv = C4::Context->userenv; > > if ( defined($userenv) >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8917
:
12831
|
12832
|
12833
|
12834
|
12998
|
12999
|
13000
|
13001
|
14058
|
14059
|
14060
|
14061
|
15669
|
15670
|
15671
|
15672
|
15711
|
15712
|
15713
|
15714
|
15715
|
15716
|
15783
|
15784
|
15785
|
15786
|
15787
|
15812
|
15815
|
15818
|
15819
|
15820
|
15821
|
15822
|
15823
|
15824
|
15825
|
15850
|
15851
|
15852
|
15853
|
15854
|
15855
|
15856
|
15857
|
15858