Attachment 157873 Details for Bug 35062 – Bug 35062: Add class plugin-blocks-submit in addbiblio

[patch] Bug 35062: Add class plugin-blocks-submit in addbiblio

Bug-35062-Add-class-plugin-blocks-submit-in-addbib.patch (text/plain), 1.77 KB, created by David Nind on 2023-10-25 19:39:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-25 19:39:06 UTC

Size: 1.77 KB

patch

obsolete

>From 85ff88817158035357a2b168fec6c00930ae3241 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 16 Oct 2023 12:08:25 +0200
>Subject: [PATCH] Bug 35062: Add class plugin-blocks-submit in addbiblio
>
>Adding this condition in Check() allows you to prevent form submittal
>during e.g. an ajax call in a framework plugin.
>The plugin adds and removes the class on the corresponding html
>element during processing.
>
>Test plan:
>Since we do not have a plugin using this class yet, nothing changes now.
>Verify that you can still click Save in addbiblio while using standard
>plugins. In other words: no change in behavior.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt   | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 73fe2521c2..26642331f8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -733,7 +733,10 @@ $(document).ready(function(){
>     function Check(){
>         var StrAlert = AreFieldsNotOk();
>         var StrWarning = AreFieldsNotOk( false );
>-        if( !StrAlert && StrWarning ){
>+        if ( $('.plugin-blocks-submit').length > 0 ) {
>+            // This class can be set by framework plugins to block submittal temporarily (e.g. during ajax call)
>+            return false;
>+        } else if( !StrAlert && StrWarning ) {
>             // Check important fields
>             $("#check_errors").html( StrWarning );
>             $('html, body').animate({ scrollTop: 0 }, 'fast');
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35062: 157226 | 157873 | 160936