Bugzilla – Attachment 157876 Details for
Bug 35157
The searchfieldstype select element produces invalid HTML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35157: Remove spans from patronfields.inc
Bug-35157-Remove-spans-from-patronfieldsinc.patch (text/plain), 8.91 KB, created by
Lucas Gass (lukeg)
on 2023-10-25 21:04:28 UTC
(
hide
)
Description:
Bug 35157: Remove spans from patronfields.inc
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-10-25 21:04:28 UTC
Size:
8.91 KB
patch
obsolete
>From d9ebdadd4d873e573d421b8670bd5e7ee2bdb9ef Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 25 Oct 2023 20:59:59 +0000 >Subject: [PATCH] Bug 35157: Remove spans from patronfields.inc > >To test: >1. Run any page that contains the "Search patrons" search bar through an HTML validator and you will see a lot of: > > Stray start tag span. > Stray end tag span. > >2. Apply patch >3. Try step 1 again, no more errors from the HTML validator. >4. Make sure the patron searches still work when limiting by 'Search field'. >--- > .../prog/en/includes/patronfields.inc | 154 +++++++++--------- > 1 file changed, 77 insertions(+), 77 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >index 777cc300bd9..f5c949bd9e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc >@@ -1,81 +1,81 @@ > [%- BLOCK patron_fields -%] >- [%- SWITCH name -%] >- [%- CASE 'standard' -%]<span>Standard</span> >- [%- CASE 'full_address' -%]<span>Full address</span> >- [%- CASE 'all_emails' -%]<span>All emails</span> >- [%- CASE 'all_phones' -%]<span>All phones</span> >- [%- CASE 'borrowernumber' -%]<span>Borrowernumber</span> >- [%- CASE 'cardnumber' -%]<span>Card number</span> >- [%- CASE 'surname' -%]<span>Surname</span> >- [%- CASE 'firstname' -%]<span>First name</span> >- [%- CASE 'middle_name' -%]<span>Middle name</span> >- [%- CASE 'title' -%]<span>Salutation</span> >- [%- CASE 'othernames' -%]<span>Other name</span> >- [%- CASE 'initials' -%]<span>Initials</span> >- [%- CASE 'pronouns' -%]<span>Pronouns</span> >- [%- CASE 'streetnumber' -%]<span>Street number</span> >- [%- CASE 'streettype' -%]<span>Street type</span> >- [%- CASE 'address' -%]<span>Address</span> >- [%- CASE 'address2' -%]<span>Address 2</span> >- [%- CASE 'city' -%]<span>City</span> >- [%- CASE 'state' -%]<span>State</span> >- [%- CASE 'zipcode' -%]<span>ZIP/Postal code</span> >- [%- CASE 'country' -%]<span>Country</span> >- [%- CASE 'email' -%]<span>Primary email</span> >- [%- CASE 'phone' -%]<span>Primary phone</span> >- [%- CASE 'mobile' -%]<span>Mobile phone</span> >- [%- CASE 'fax' -%]<span>Fax</span> >- [%- CASE 'emailpro' -%]<span>Secondary email</span> >- [%- CASE 'phonepro' -%]<span>Secondary phone</span> >- [%- CASE 'B_streetnumber' -%]<span>Alternate street number</span> >- [%- CASE 'B_streettype' -%]<span>Alternate street type</span> >- [%- CASE 'B_address' -%]<span>Alternate address</span> >- [%- CASE 'B_address2' -%]<span>Alternate address line 2</span> >- [%- CASE 'B_city' -%]<span>Alternate city</span> >- [%- CASE 'B_state' -%]<span>Alternate state</span> >- [%- CASE 'B_zipcode' -%]<span>Alternate zip code</span> >- [%- CASE 'B_country' -%]<span>Alternate country</span> >- [%- CASE 'B_email' -%]<span>Alternate email</span> >- [%- CASE 'B_phone' -%]<span>Alternate phone</span> >- [%- CASE 'dateofbirth' -%]<span>Date of birth</span> >- [%- CASE 'branchcode' -%]<span>Library (code)</span> >- [%- CASE 'categorycode' -%]<span>Category (code)</span> >- [%- CASE 'dateenrolled' -%]<span>Registration date</span> >- [%- CASE 'dateexpiry' -%]<span>Expiry date</span> >- [%- CASE 'gonenoaddress' -%]<span>Gone no address</span> >- [%- CASE 'lost' -%]<span>Lost card</span> >- [%- CASE 'debarred' -%]<span>Restricted</span> >- [%- CASE 'debarredcomment' -%]<span>Restriction reason</span> >- [%- CASE 'contactname' -%]<span>Guarantor surname</span> >- [%- CASE 'contactfirstname' -%]<span>Guarantor firstname</span> >- [%- CASE 'contacttitle' -%]<span>Guarantor title</span> >- [%- CASE 'guarantorid' -%]<span>Guarantor ID</span> >- [%- CASE 'borrowernotes' -%]<span>Circulation note</span> >- [%- CASE 'relationship' -%]<span>Guarantor relationship</span> >- [%- CASE 'sex' -%]<span>Gender</span> >- [%- CASE 'flags' -%]<span>Permissions (code)</span> >- [%- CASE 'userid' -%]<span>Username</span> >- [%- CASE 'opacnote' -%]<span>OPAC note</span> >- [%- CASE 'contactnote' -%]<span>Contact note</span> >- [%- CASE 'sort1' -%]<span>Sort 1</span> >- [%- CASE 'sort2' -%]<span>Sort 2</span> >- [%- CASE 'altcontactfirstname' -%]<span>Alternate contact first name</span> >- [%- CASE 'altcontactsurname' -%]<span>Alternate contact surname</span> >- [%- CASE 'altcontactaddress1' -%]<span>Alternate contact address</span> >- [%- CASE 'altcontactaddress2' -%]<span>Alternate contact address 2</span> >- [%- CASE 'altcontactaddress3' -%]<span>Alternate contact city</span> >- [%- CASE 'altcontactstate' -%]<span>Alternate contact state</span> >- [%- CASE 'altcontactzipcode' -%]<span>Alternate contact ZIP/postal code</span> >- [%- CASE 'altcontactcountry' -%]<span>Alternate contact country</span> >- [%- CASE 'altcontactphone' -%]<span>Alternate contact phone</span> >- [%- CASE 'smsalertnumber' -%]<span>SMS alert number</span> >- [%- CASE 'sms_provider_id' -%]<span>SMS provider</span> >- [%- CASE 'privacy' -%]<span>Privacy (code)</span> >- [%- CASE 'privacy_guarantor_checkouts' -%]<span>Guarantor can view checkouts</span> >- [%- CASE 'updated_on' -%]<span>Last updated</span> >- [%- CASE 'lastseen' -%]<span>Last seen</span> >- [%- CASE 'checkprevcheckout' -%]<span>Check previous checkout</span> >- [%- CASE DEFAULT -%] >+ [%- SWITCH name -%] >+ [%- CASE 'standard' -%]Standard >+ [%- CASE 'full_address' -%]Full address >+ [%- CASE 'all_emails' -%]All emails >+ [%- CASE 'all_phones' -%]All phones >+ [%- CASE 'borrowernumber' -%]Borrowernumber >+ [%- CASE 'cardnumber' -%]Card number >+ [%- CASE 'surname' -%]Surname >+ [%- CASE 'firstname' -%]First name >+ [%- CASE 'middle_name' -%]Middle name >+ [%- CASE 'title' -%]Salutation >+ [%- CASE 'othernames' -%]Other name >+ [%- CASE 'initials' -%]Initials >+ [%- CASE 'pronouns' -%]Pronouns >+ [%- CASE 'streetnumber' -%]Street number >+ [%- CASE 'streettype' -%]Street type >+ [%- CASE 'address' -%]Address >+ [%- CASE 'address2' -%]Address 2 >+ [%- CASE 'city' -%]City >+ [%- CASE 'state' -%]State >+ [%- CASE 'zipcode' -%]ZIP/Postal code >+ [%- CASE 'country' -%]Country >+ [%- CASE 'email' -%]Primary email >+ [%- CASE 'phone' -%]Primary phone >+ [%- CASE 'mobile' -%]Mobile phone >+ [%- CASE 'fax' -%]Fax >+ [%- CASE 'emailpro' -%]Secondary email >+ [%- CASE 'phonepro' -%]Secondary phone >+ [%- CASE 'B_streetnumber' -%]Alternate street number >+ [%- CASE 'B_streettype' -%]Alternate street type >+ [%- CASE 'B_address' -%]Alternate address >+ [%- CASE 'B_address2' -%]Alternate address line 2 >+ [%- CASE 'B_city' -%]Alternate city >+ [%- CASE 'B_state' -%]Alternate state >+ [%- CASE 'B_zipcode' -%]Alternate zip code >+ [%- CASE 'B_country' -%]Alternate country >+ [%- CASE 'B_email' -%]Alternate email >+ [%- CASE 'B_phone' -%]Alternate phone >+ [%- CASE 'dateofbirth' -%]Date of birth >+ [%- CASE 'branchcode' -%]Library (code) >+ [%- CASE 'categorycode' -%]Category (code) >+ [%- CASE 'dateenrolled' -%]Registration date >+ [%- CASE 'dateexpiry' -%]Expiry date >+ [%- CASE 'gonenoaddress' -%]Gone no address >+ [%- CASE 'lost' -%]Lost card >+ [%- CASE 'debarred' -%]Restricted >+ [%- CASE 'debarredcomment' -%]Restriction reason >+ [%- CASE 'contactname' -%]Guarantor surname >+ [%- CASE 'contactfirstname' -%]Guarantor firstname >+ [%- CASE 'contacttitle' -%]Guarantor title >+ [%- CASE 'guarantorid' -%]Guarantor ID >+ [%- CASE 'borrowernotes' -%]Circulation note >+ [%- CASE 'relationship' -%]Guarantor relationship >+ [%- CASE 'sex' -%]Gender >+ [%- CASE 'flags' -%]Permissions (code) >+ [%- CASE 'userid' -%]Username >+ [%- CASE 'opacnote' -%]OPAC note >+ [%- CASE 'contactnote' -%]Contact note >+ [%- CASE 'sort1' -%]Sort 1 >+ [%- CASE 'sort2' -%]Sort 2 >+ [%- CASE 'altcontactfirstname' -%]Alternate contact first name >+ [%- CASE 'altcontactsurname' -%]Alternate contact surname >+ [%- CASE 'altcontactaddress1' -%]Alternate contact address >+ [%- CASE 'altcontactaddress2' -%]Alternate contact address 2 >+ [%- CASE 'altcontactaddress3' -%]Alternate contact city >+ [%- CASE 'altcontactstate' -%]Alternate contact state >+ [%- CASE 'altcontactzipcode' -%]Alternate contact ZIP/postal code >+ [%- CASE 'altcontactcountry' -%]Alternate contact country >+ [%- CASE 'altcontactphone' -%]Alternate contact phone >+ [%- CASE 'smsalertnumber' -%]SMS alert number >+ [%- CASE 'sms_provider_id' -%]SMS provider >+ [%- CASE 'privacy' -%]Privacy (code) >+ [%- CASE 'privacy_guarantor_checkouts' -%]Guarantor can view checkouts >+ [%- CASE 'updated_on' -%]Last updated >+ [%- CASE 'lastseen' -%]Last seen >+ [%- CASE 'checkprevcheckout' -%]Check previous checkout >+ [%- CASE DEFAULT -%] > [%- END -%] > [%- END -%] > [%- BLOCK patron_fields_dropdown -%] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35157
:
157876
|
158010
|
158226
|
159112
|
159197