Attachment 157898 Details for Bug 34924 – Bug 34924: Adjust auto renewal email to reflect success for final renewals

[patch] Bug 34924: Adjust auto renewal email to reflect success for final renewals

Bug-34924-Adjust-auto-renewal-email-to-reflect-suc.patch (text/plain), 2.96 KB, created by Martin Renvoize (ashimema) on 2023-10-26 08:52:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-10-26 08:52:33 UTC

Size: 2.96 KB

patch

obsolete

>From aebbd1beb85853fdbee11cbe41c7b49e13655668 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 23 Oct 2023 17:52:11 +0000
>Subject: [PATCH] Bug 34924: Adjust auto renewal email to reflect success for
> final renewals
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../data/mysql/en/mandatory/sample_notices.yml     | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 9b0880679d3..e50ffb97a25 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -2145,7 +2145,13 @@ tables:
>           lang: default
>           content:
>             - "Dear [% borrower.firstname %] [% borrower.surname %],"
>-            - "[% IF checkout.auto_renew_error %]"
>+            - "[% IF checkout.auto_renew_error == 'auto_renew_final' %]"
>+            - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]"
>+            - "This item has reached the maximum number of automatic renewals and will no longer be renewed."
>+            - "[% ELSIF checkout.auto_renew_error == 'auto_unseen_final' %]"
>+            - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]"
>+            - "This item has reached the maximum number of unseen renewals and will need to be renewed at the library."
>+            - "[% ELSIF checkout.auto_renew_error %]"
>             - "The following item, [% biblio.title %], has not been renewed because:"
>             - "[% IF checkout.auto_renew_error == 'too_many' %]"
>             - "You have reached the maximum number of renewals possible."
>@@ -2163,12 +2169,6 @@ tables:
>             - "This item must be renewed at the library."
>             - "[% ELSIF checkout.auto_renew_error == 'auto_account_expired' %]"
>             - "Your account has expired."
>-            - "[% ELSIF checkout.auto_renew_error == 'auto_renew_final' %]"
>-            - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]"
>-            - "This item has reached the maximum number of automatic renewals and will no longer be renewed."
>-            - "[% ELSIF checkout.auto_renew_error == 'auto_unseen_final' %]"
>-            - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]"
>-            - "This item has reached the maximum number of unseen renewals and will need to be renewed at the library."
>             - "[% END %]"
>             - "[% ELSE %]"
>             - "The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %]"
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 34924: 156239 | 156240 | 156241 | 157290 | 157291 | 157292 | 157687 | 157688 | 157689 | 157690 | 157895 | 157896 | 157897 | 157898 | 157929 | 157930 | 157931 | 157932 | 157933 | 168642