Attachment 15790 Details for Bug 9737 – Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists

[patch] Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists

0001-Bug-9737-Local-Covers-sometimes-appear-then-disappea.patch (text/plain), 3.23 KB, created by David Cook on 2013-03-01 02:48:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2013-03-01 02:48:17 UTC

Size: 3.23 KB

patch

obsolete

>From 85073ea378a51caba898d7b3f5da7d394dbcf342 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 1 Mar 2013 13:22:33 +1100
>Subject: [PATCH] Bug 9737 - Local Covers sometimes appear then disappear on
> OPAC Search Results/Lists
>
>The current problem:
>
>When the verify_images() function runs from amazonimages.js, it loops through every img element and selects the elements that come from Amazon sources.
>
>However, if the height/width is 1 (i.e. Amazon passes off a blank image) or if the img element's complete property is null or non-existent, then it searches for the parent node and re-writes the HTML with the "No Cover Image Available" (NO_AMAZON_IMAGE) text, even though that parent node might contain other img elements that have images available (from Google, local images, etc)!
>
>Proposed fix:
>
>Wrap the Amazon image in a span tag (as we do with the Google and local covers), so that it re-writes the HTML within that parent span, rather than the parent anchor which contains all the other images.
>
>To test:
>
>1) Turn on the OPACAmazonCoverImages, GoogleJackets, and OPACLocalCoverImages system preferences
>2) Replace the ISBN in one of your records with 9780615352435
>3) Now load a local cover image for that record
>4) Search for that record (but make sure you're vague enough to have multiple search results)
>5) For a split second, you may notice the local cover image appears before being replaced by a "No Cover Image Available".
>
>Now apply this patch
>
>6) Refresh your search results page
>7) You should now see your local cover image, PLUS the "No Cover Image Available" for the Amazon image, and whatever other graphics/"no cover image available" "graphics" for the Google Jackets.
>---
> .../opac-tmpl/prog/en/modules/opac-results.tt | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 30682c4..4563cff 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -663,7 +663,7 @@ $(document).ready(function(){
> </td><td>
> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">
> [% IF ( OPACLocalCoverImages ) %][% END %]
>- [% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
>+ [% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
> 
> [% IF ( SyndeticsEnabled ) %]
> [% IF ( SyndeticsCoverImages ) %]
>-- 
>1.7.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 9737: 15790 | 15791 | 16447 | 17180