Attachment 15791 Details for Bug 9737 – Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists [Revised to include lists]

[patch] Bug 9737 - Local Covers sometimes appear then disappear on OPAC Search Results/Lists [Revised to include lists]

0001-Bug-9737-Local-Covers-sometimes-appear-then-disappea.patch (text/plain), 8.28 KB, created by David Cook on 2013-03-01 02:57:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2013-03-01 02:57:23 UTC

Size: 8.28 KB

patch

obsolete

>From bb58677fe843cbf9c1e6c9f69aab3b8ddc746958 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 1 Mar 2013 13:22:33 +1100
>Subject: [PATCH] Bug 9737 - Local Covers sometimes appear then disappear on
> OPAC Search Results/Lists
>
>The current problem:
>
>When the verify_images() function runs from amazonimages.js, it loops through every img element and selects the elements that come from Amazon sources.
>
>However, if the height/width is 1 (i.e. Amazon passes off a blank image) or if the img element's complete property is null or non-existent, then it searches for the parent node and re-writes the HTML with the "No Cover Image Available" (NO_AMAZON_IMAGE) text, even though that parent node might contain other img elements that have images available (from Google, local images, etc)!
>
>Proposed fix:
>
>Wrap the Amazon image in a span tag (as we do with the Google and local covers), so that it re-writes the HTML within that parent span, rather than the parent anchor which contains all the other images.
>
>To test:
>
>1) Turn on the OPACAmazonCoverImages, GoogleJackets, and OPACLocalCoverImages system preferences
>2) Replace the ISBN in one of your records with 9780615352435
>3) Now load a local cover image for that record
>4) Search for that record (but make sure you're vague enough to have multiple search results)
>5) For a split second, you may notice the local cover image appears before being replaced by a "No Cover Image Available".
>
>Now apply this patch
>
>6) Refresh your search results page
>7) You should now see your local cover image, PLUS the "No Cover Image Available" for the Amazon image, and whatever other graphics/"no cover image available" "graphics" for the Google Jackets.
>
>To be comprehensive, try the same set of steps using the OPAC Lists rather than the OPAC Search Results
>---
> .../opac-tmpl/prog/en/modules/opac-results.tt | 6 +++---
> .../opac-tmpl/prog/en/modules/opac-shelves.tt | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 30682c4..bd7066c 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -663,15 +663,15 @@ $(document).ready(function(){
> </td><td>
> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">
> [% IF ( OPACLocalCoverImages ) %][% END %]
>- [% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
>+ [% IF ( OPACAmazonCoverImages ) %][% IF ( SEARCH_RESULT.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
> 
> [% IF ( SyndeticsEnabled ) %]
> [% IF ( SyndeticsCoverImages ) %]
> [% IF SEARCH_RESULT.normalized_isbn %]
> [% IF ( using_https ) %]
>- <img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% SEARCH_RESULT.normalized_upc %]&amp;oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" />
>+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% SEARCH_RESULT.normalized_upc %]&amp;oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" />
> [% ELSE %]
>- <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% SEARCH_RESULT.normalized_upc %]&amp;oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" />
>+ <img src="http://www.syndetics.com/index.aspx?isbn=[% SEARCH_RESULT.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% SEARCH_RESULT.normalized_upc %]&amp;oclc=[% SEARCH_RESULT.normalized_oclc %]" alt="" class="thumbnail" />
> [% END %]
> [% ELSE %]
> No cover image available
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>index d6c1ed5..eb35943 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
>@@ -433,12 +433,12 @@ $(function() {
> <td>
> <a class="p1" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% itemsloo.biblionumber %]">
> [% IF ( OPACLocalCoverImages ) %][% END %]
>- [% IF ( OPACAmazonCoverImages ) %][% IF ( itemsloo.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% itemsloo.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
>+ [% IF ( OPACAmazonCoverImages ) %][% IF ( itemsloo.normalized_isbn ) %]<img src="http://images.amazon.com/images/P/[% itemsloo.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />[% ELSE %]No cover image available[% END %][% END %]
> 
> [% IF ( SyndeticsEnabled ) %][% IF ( SyndeticsCoverImages ) %][% IF ( using_https ) %]
>- <img src="https://secure.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% itemsloo.normalized_upc %]&amp;oclc=[% itemsloo.normalized_oclc %]" alt="" class="thumbnail" />
>+ <img src="https://secure.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% itemsloo.normalized_upc %]&amp;oclc=[% itemsloo.normalized_oclc %]" alt="" class="thumbnail" />
> [% ELSE %]
>- <img src="http://www.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% itemsloo.normalized_upc %]&amp;oclc=[% itemsloo.normalized_oclc %]" alt="" class="thumbnail" />[% END %][% END %][% END %]
>+ <img src="http://www.syndetics.com/index.aspx?isbn=[% itemsloo.normalized_isbn %]/SC.GIF&amp;client=[% SyndeticsClientCode %]&amp;type=xw10&amp;upc=[% itemsloo.normalized_upc %]&amp;oclc=[% itemsloo.normalized_oclc %]" alt="" class="thumbnail" />[% END %][% END %][% END %]
> 
> [% IF ( GoogleJackets ) %][% IF ( itemsloo.normalized_isbn ) %]<div style="block" title="[% itemsloo.biblionumber |url %]" class="[% itemsloo.normalized_isbn %]" id="gbs-thumbnail[% loop.count %]"></div>[% ELSE %]No cover image available[% END %][% END %]
> [% IF OpenLibraryCovers %][% IF itemsloo.normalized_isbn %][% ELSE %]No cover image available[% END %][% END %]
>-- 
>1.7.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 9737: 15790 | 15791 | 16447 | 17180