Attachment 157954 Details for Bug 35167 – Bug 35167: Regression tests

[patch] Bug 35167: Regression tests

Bug-35167-Regression-tests.patch (text/plain), 1.60 KB, created by Lucas Gass (lukeg) on 2023-10-26 20:20:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-10-26 20:20:55 UTC

Size: 1.60 KB

patch

obsolete

>From 69daf88148563ff0c29982326206265abd5e3f29 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 26 Oct 2023 14:56:35 -0300
>Subject: [PATCH] Bug 35167: Regression tests
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> t/db_dependent/api/v1/items.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/items.t b/t/db_dependent/api/v1/items.t
>index 6a22356254d..6b72b22ccb8 100755
>--- a/t/db_dependent/api/v1/items.t
>+++ b/t/db_dependent/api/v1/items.t
>@@ -256,7 +256,7 @@ subtest 'list_public() tests' => sub {
> 
> subtest 'get() tests' => sub {
> 
>-    plan tests => 30;
>+    plan tests => 34;
> 
>     $schema->storage->txn_begin;
> 
>@@ -333,6 +333,13 @@ subtest 'get() tests' => sub {
>       ->json_is( '/not_for_loan_status' => 0, 'not_for_loan_status is 0' )
>       ->json_is( '/effective_not_for_loan_status' => 2, 'effective_not_for_loan_status now picks up itemtype level - item-level_itypes:1' );
> 
>+    $itype->notforloan(undef)->store();
>+    $t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber )->status_is( 200, 'SWAGGER3.2.2' )
>+        ->json_is( '/not_for_loan_status' => 0, 'not_for_loan_status is 0' )->json_is(
>+        '/effective_not_for_loan_status' => 0,
>+        'effective_not_for_loan_status now picks up itemtype level and falls back to 0 because undef'
>+        );
>+
>     t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
>     $t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber )
>       ->status_is( 200, 'SWAGGER3.2.2' )
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35167: 157948 | 157949 | 157954 | 157955 | 157968 | 157969