Attachment 157970 Details for Bug 34678 – Bug 34678: Unit test

[patch] Bug 34678: Unit test

Bug-34678-Unit-test.patch (text/plain), 2.46 KB, created by Marcel de Rooy on 2023-10-27 06:45:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-27 06:45:16 UTC

Size: 2.46 KB

patch

obsolete

>From 42c27f1bb420ea84fbfec4cbd5fc11c14844b817 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 13 Sep 2023 17:01:09 +0000
>Subject: [PATCH] Bug 34678: Unit test
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Reserves.t | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 6eb8000e17..85a148f96c 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -1764,7 +1764,7 @@ subtest 'DefaultHoldExpiration tests' => sub {
> };
> 
> subtest '_Findgroupreserves' => sub {
>-    plan tests => 4;
>+    plan tests => 6;
>     $schema->storage->txn_begin;
> 
>     my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } );
>@@ -1791,8 +1791,8 @@ subtest '_Findgroupreserves' => sub {
>     C4::HoldsQueue::AddToHoldTargetMap(
>         {
>             $item->id => {
>-                borrowernumber => $patron_1->id, biblionumber => $item->biblionumber,
>-                holdingbranch  => $item->holdingbranch, item_level => 0, reserve_id => $reserve_id_1
>+                borrowernumber => $patron_1->id,        biblionumber => $item->biblionumber,
>+                holdingbranch  => $item->holdingbranch, item_level   => 0, reserve_id => $reserve_id_1
>             }
>         }
>     );
>@@ -1816,6 +1816,22 @@ subtest '_Findgroupreserves' => sub {
>     is( scalar @reserves,           1,             "We should only get the item level hold that is in the map" );
>     is( $reserves[0]->{reserve_id}, $reserve_id_2, "We got the expected reserve" );
> 
>+    C4::HoldsQueue::AddToHoldTargetMap(
>+        {
>+            $item_2->id => {
>+                borrowernumber => $patron_2->id, biblionumber => $item->biblionumber,
>+                holdingbranch  => $item->holdingbranch, item_level => 1, reserve_id => $reserve_id_1
>+            }
>+        }
>+    );
>+
>+    # When the hold is title level and in the hold fill targets we expect this to be the only hold returned
>+    @reserves = C4::Reserves::_Findgroupreserve( $item->biblionumber, $item_2->id, 0, [] );
>+    is( scalar @reserves,           1,             "We should still only get the item level hold that is in the map" );
>+    is( $reserves[0]->{reserve_id}, $reserve_id_1, "We got the expected reserve which has been updated" );
>+
>+
>+
>     $schema->txn_rollback;
> };
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34678: 155594 | 155595 | 155628 | 155629 | 157913 | 157914 | 157950 | 157951 | 157970 | 157971