Attachment 157974 Details for Bug 35141 – Bug 35141: (QA follow-up) Increment the bad count

[patch] Bug 35141: (QA follow-up) Increment the bad count

Bug-35141-QA-follow-up-Increment-the-bad-count.patch (text/plain), 1.40 KB, created by Marcel de Rooy on 2023-10-27 07:28:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-27 07:28:12 UTC

Size: 1.40 KB

patch

obsolete

>From 39901fcd473d37f5f92d83fb34c5ab7aad4afef9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 27 Oct 2023 07:21:03 +0000
>Subject: [PATCH] Bug 35141: (QA follow-up) Increment the bad count
>Content-Type: text/plain; charset=utf-8
>
>Also move earlier print to warn for consistency.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> misc/link_bibs_to_authorities.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/misc/link_bibs_to_authorities.pl b/misc/link_bibs_to_authorities.pl
>index 3dfdd049b7..78b0dd2687 100755
>--- a/misc/link_bibs_to_authorities.pl
>+++ b/misc/link_bibs_to_authorities.pl
>@@ -202,10 +202,9 @@ sub process_bib {
>     my $allowrelink = $args->{allowrelink};
>     my $biblio = Koha::Biblios->find($biblionumber);
>     my $record;
>-    eval{ $record = $biblio->metadata->record; };
>+    eval { $record = $biblio->metadata->record; };
>     unless ( defined $record ) {
>-        print
>-"\nCould not retrieve bib $biblionumber from the database - record is corrupt.\n";
>+        warn "Could not retrieve bib $biblionumber from the database - record is corrupt.";
>         $num_bad_bibs++;
>         return;
>     }
>@@ -220,6 +219,7 @@ sub process_bib {
>     };
>     if ($@) {
>         warn "Error while searching for authorities for biblionumber $biblionumber at " . localtime(time);
>+        $num_bad_bibs++;
>         return;
>     }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35141: 157738 | 157739 | 157766 | 157767 | 157972 | 157973 | 157974