Attachment 157975 Details for Bug 35003 – Bug 35003: Make cancelled hold requests filter by branch

[patch] Bug 35003: Make cancelled hold requests filter by branch

Bug-35003-Make-cancelled-hold-requests-filter-by-b.patch (text/plain), 1.62 KB, created by Marcel de Rooy on 2023-10-27 09:35:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-10-27 09:35:03 UTC

Size: 1.62 KB

patch

obsolete

>From 49a779645e3b52f0878fa4dd52bae88f417f8050 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 6 Oct 2023 15:15:39 +0000
>Subject: [PATCH] Bug 35003: Make cancelled hold requests filter by branch
>Content-Type: text/plain; charset=utf-8
>
>To recreate:
>1. Make sure you have the "Default waiting hold cancellation policy" set to allow via circulation rules.
>2. Make several holds at different branches  holds and set them to waiting
>3. Request to cancel those holds, making sure you cancel some for different branches.
>4. Go to waitingreserves.tt and notice that you see all of the holds from all branches.
>5. APPLY PATCH and restart services
>6. Vist the waitingreserves.tt page and notice that the "Holds with cancellation requests" table can now filters by branch.
>7. Use the "View all libraries" and make sure you can see all the holds with a cancellation request.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> circ/waitingreserves.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/circ/waitingreserves.pl b/circ/waitingreserves.pl
>index 2e56c5e86f..26924f27fd 100755
>--- a/circ/waitingreserves.pl
>+++ b/circ/waitingreserves.pl
>@@ -116,7 +116,7 @@ while ( my $hold = $holds->next ) {
>     
> }
> 
>-my $holds_with_cancellation_requests = Koha::Holds->waiting->filter_by_has_cancellation_requests;
>+my $holds_with_cancellation_requests = Koha::Holds->waiting->search({ ($all_branches ? () : ( branchcode => $default ) ) })->filter_by_has_cancellation_requests;
> 
> $template->param(cancel_result => \@cancel_result) if @cancel_result;
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35003: 156633 | 157874 | 157975