Bugzilla – Attachment 15798 Details for
Bug 9377
itemtype in duplicate biblio search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9377 - itemtype in duplicate biblio search
Bug-9377---itemtype-in-duplicate-biblio-search.patch (text/plain), 1.93 KB, created by
Marcel de Rooy
on 2013-03-01 11:00:31 UTC
(
hide
)
Description:
Bug 9377 - itemtype in duplicate biblio search
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-03-01 11:00:31 UTC
Size:
1.93 KB
patch
obsolete
>From e69908f8af2dfc95c900e1c2020b12e63d433e84 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Fri, 11 Jan 2013 10:33:53 +0100 >Subject: [PATCH] Bug 9377 - itemtype in duplicate biblio search >Content-Type: text/plain; charset="utf-8" > >In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds : >$query .= " and itemtype=$result->{itemtype}". >This should be only when itemtype is defined in biblio and not in items. > >Test plan : >On a database with itemtype mapped in biblioitems and "item-level_itypes" syspref on "biblio record" : >- Go to a biblio details page >- Click on "Edit as new (duplicate)" >- If ISBN is defined, remove it >- Click on save >=> a duplicate is detected >- Change biblio item type >- Click on save >=> no duplicate detected >- Set "item-level_itypes" syspref to "specific record" >- Come back to biblio details page >- Click on "Edit as new (duplicate)" >- If ISBN is defined, remove it >- Click on save >=> a duplicate is detected >- Change biblio item type >=> a duplicate is detected > >Signed-off-by: Marc Veron <veron@veron.ch> >Followed test plan. Behaves as expected. >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Search.pm | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 50f7d2b..348c46f 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -112,8 +112,13 @@ sub FindDuplicate { > # quotes around the value > $result->{title} =~ s/(and|or|not)//g; > $query = "ti,ext=$result->{title}"; >- $query .= " and itemtype=$result->{itemtype}" >- if ( $result->{itemtype} ); >+ >+ if ( $result->{itemtype} >+ && !C4::Context->preference('item-level_itypes') ) >+ { >+ $query .= " and itemtype=$result->{itemtype}"; >+ } >+ > if ( $result->{author} ) { > $result->{author} =~ s /\\//g; > $result->{author} =~ s /\"//g; >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9377
:
14535
|
14557
|
15798
|
15942
|
15964