Bugzilla – Attachment 157985 Details for
Bug 35119
Make bibliographic encoding errors more prominent and match current styling
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35119: Add back classes used for selenium tests
Bug-35119-Add-back-classes-used-for-selenium-tests.patch (text/plain), 2.57 KB, created by
Martin Renvoize (ashimema)
on 2023-10-27 14:50:57 UTC
(
hide
)
Description:
Bug 35119: Add back classes used for selenium tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-10-27 14:50:57 UTC
Size:
2.57 KB
patch
obsolete
>From 04de4c7f7959d45ae231510529ce668a5e9baf89 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 27 Oct 2023 15:46:13 +0100 >Subject: [PATCH] Bug 35119: Add back classes used for selenium tests > >This patch re-instates the classes used for the selenium tests.. I >checked we weren't using them for javascript or css, but didn't think >about tests before. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- > t/db_dependent/selenium/regressions.t | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 88630069da2..5671a3d7db1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -107,12 +107,12 @@ > <h1>Errors found</h1> > [% IF decoding_error %] > <h2>Encoding errors</h2> >- <p>There is at least one encoding error with this bibliographic record, the view may be degraded.</p> >+ <p class="biberror">There is at least one encoding error with this bibliographic record, the view may be degraded.</p> > <pre class="error">[% decoding_error | html %]</pre> > [% END %] > [% IF analytics_error %] > <h2>Analytics errors</h2> >- <p>There was an error searching for analytic records, please see the logs for details.</p> >+ <p class="analytics_error">There was an error searching for analytic records, please see the logs for details.</p> > [% END %] > </div> > [% END %] >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 04aed37e296..b9e9cb2edfd 100755 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -124,8 +124,8 @@ subtest 'Bibliographic record detail page must not explode even with invalid met > > $driver->get( $base_url . "/catalogue/detail.pl?biblionumber=$biblionumber" ); > >- my $biberror = $driver->find_element('//span[@class="biberror"]')->get_text(); >- is( $biberror, "There is an error with this bibliographic record, the view may be degraded."); >+ my $biberror = $driver->find_element('//p[@class="biberror"]')->get_text(); >+ is( $biberror, "There is at least one encoding error with this bibliographic record, the view may be degraded."); > push @cleanup, $biblio; > }; > >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35119
:
157529
|
157538
|
157553
|
157561
|
157577
|
157578
|
157641
|
157643
|
157644
|
157645
|
157984
| 157985