Bugzilla – Attachment 157990 Details for
Bug 35111
Background jobs worker crashes on SIGPIPE when database connection lost in Ubuntu 22.04
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35111: Ignore SIGPIPE in background jobs worker
Bug-35111-Ignore-SIGPIPE-in-background-jobs-worker.patch (text/plain), 1.85 KB, created by
Victor Grousset/tuxayo
on 2023-10-27 15:40:16 UTC
(
hide
)
Description:
Bug 35111: Ignore SIGPIPE in background jobs worker
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2023-10-27 15:40:16 UTC
Size:
1.85 KB
patch
obsolete
>From ab9ef7cc98844c47f5826ce6d4ddca3676cde2e9 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 20 Oct 2023 01:15:00 +0000 >Subject: [PATCH] Bug 35111: Ignore SIGPIPE in background jobs worker > >This change explicitly ignores SIGPIPE signals in the background jobs >worker. > >Daemons like Starman ignore SIGPIPE so it makes sense to explicitly set this. >Differences in the inner workings of MySQL vs MariaDB client libraries have yielded >different behaviours in automatic reconnections and potentially SIGPIPE handling, >so this helps to make the overall behaviour more consistent. > >Test plan: >0. Apply patch and run "restart_all" >1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 >2. Click "Save" > "MARCXML" >3. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl >4. Click "Choose file", choose the MARCXML file, click "Upload file" >5. Click "Stage for import" >6. Note the job is marked as "100% Finished" > >7. In a separate window run "docker restart koha-db-1" >8. Repeat steps 3-5 for uploading file and running stage for import >9. Note that the job is marked as "100% Finished" as you'd expect > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >[EDIT] Added comment on the SIG PIPE line. >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > misc/workers/background_jobs_worker.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/misc/workers/background_jobs_worker.pl b/misc/workers/background_jobs_worker.pl >index 27ae8ff9be..fde3432143 100755 >--- a/misc/workers/background_jobs_worker.pl >+++ b/misc/workers/background_jobs_worker.pl >@@ -64,6 +64,8 @@ use Koha::Logger; > use Koha::BackgroundJobs; > use C4::Context; > >+$SIG{'PIPE'} = 'IGNORE'; # See BZ 35111; added to ignore PIPE error when connection lost on Ubuntu. >+ > my ( $help, @queues ); > > my $max_processes = $ENV{MAX_PROCESSES}; >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35111
:
157484
|
157786
| 157990