Attachment 158011 Details for Bug 27992 – Bug 27992: Call AddReturn on stats patron

[patch] Bug 27992: Call AddReturn on stats patron

Bug-27992-Call-AddReturn-on-stats-patron.patch (text/plain), 3.96 KB, created by Lucas Gass (lukeg) on 2023-10-27 23:37:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-10-27 23:37:05 UTC

Size: 3.96 KB

patch

obsolete

>From ede0b2393bfe25813b65947a45b772823888752f Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 27 Oct 2023 23:36:05 +0000
>Subject: [PATCH] Bug 27992: Call AddReturn on stats patron
>
>---
> C4/Circulation.pm                             | 16 +++++++++--
> .../prog/en/modules/circ/circulation.tt       | 27 ++++++++++++++++++-
> 2 files changed, 40 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 2e9ed52bdcd..fe3964230c9 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -826,8 +826,20 @@ sub CanBookBeIssued {
>                 interface      => C4::Context->interface,
>             }
>         );
>-        ModDateLastSeen( $item_object->itemnumber ); # FIXME Move to Koha::Item
>-        return( { STATS => 1 }, {});
>+        my $block_lost_return = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0;
>+        my ( $stats_return, $stats_messages, $stats_iteminformation, $stats_borrower) =
>+        AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} );
>+        ModDateLastSeen( $item_object->itemnumber, $block_lost_return ); # FIXME Move to Koha::Item
>+        return (
>+            {
>+                STATS     => 1,
>+                CHECKEDIN => $stats_return,
>+                MESSAGES  => $stats_messages,
>+                ITEM      => $stats_iteminformation,
>+                BORROWER  => $stats_borrower,
>+            },
>+            {}
>+        );
>     }
> 
>     if ( $patron->gonenoaddress && $patron->gonenoaddress == 1 ) {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index dfc42a6b9e1..dc612cb2a7c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -417,8 +417,33 @@
> 
>                                 [% IF ( STATS ) %]
>                                     <li>Local use recorded</li>
>+                                    [% IF ( CHECKEDIN ) %]
>+                                        <li>Item returned from: [% INCLUDE 'patron-title.inc' patron=BORROWER %]</li>
>+                                    [% END %]
>+                                    [% IF ( MESSAGES.ResFound ) %]
>+                                        <li>Item on hold, please checkin.</li>
>+                                    [% END %]
>+                                    [% IF ( MESSAGES.ReturnClaims ) %]
>+                                        <li>Item claimed returned, please checkin.</li>
>+                                    [% END %]
>+                                    [% IF ( MESSAGES.RecallFound ) %]
>+                                        <li>Item can fill a recall, please checkin.</li>
>+                                    [% END %]
>+                                    [% IF ( MESSAGES.WasLost ) %]
>+                                        [% IF ( Koha.Preference('BlockReturnOfLostItems') ) %]
>+                                            <li>Item was lost, cannot be returned.</li>
>+                                        [% ELSE %]
>+                                            <li>Item was lost, now found.</li>
>+                                        [% END %]
>+                                    [% END %]
>+                                    [% IF ( MESSAGES.withdrawn ) %]
>+                                        [% IF ( Koha.Preference('BlockReturnOfWithdrawnItems') ) %]
>+                                            <li>Item was withdrawn, cannot be returned.</li>
>+                                        [% ELSE %]
>+                                            <li>Item was withdrawn</li>
>+                                        [% END %]
>+                                    [% END %]
>                                 [% END %]
>-
>                                 [% IF ( INVALID_DATE ) %]
>                                     <li>The due date &quot;[% INVALID_DATE | $KohaDates %]&quot; is invalid</li>
>                                 [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 27992: 126865 | 127189 | 128633 | 128634 | 146041 | 158011 | 158073 | 158086 | 158216 | 158217 | 158462 | 158463 | 158464 | 158465 | 158900