Attachment 158054 Details for Bug 35186 – Bug 35186: Remove unnecessary html tags from PASSWORD notices

[patch] Bug 35186: Remove unnecessary html tags from PASSWORD notices

Bug-35186-Remove-unnecessary-html-tags-from-PASSWO.patch (text/plain), 2.39 KB, created by David Nind on 2023-10-29 23:10:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-29 23:10:45 UTC

Size: 2.39 KB

patch

obsolete

>From be844c3db24e6d262d8c34b326e3fb53b3d5ff7c Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 29 Oct 2023 15:42:36 +0000
>Subject: [PATCH] Bug 35186: Remove unnecessary html tags from PASSWORD notices
>
>In HTML notices we don't need to explicitly use <html></html>.
>
>This removes them from the 2 notices using them:
>* PASSWORD_RESET
>* STAFF_PASSWORD_RESET
>
>To test:
>* Apply patch
>* Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress)
>* Make sure your patron has an email set
>* In patron account, use "More > Send password reset"
>* Log out
>* In the OPAC, request password reset ("forgot your password?")
>* Verify both notices appear nicely formatted (line breaks, bold, etc.)
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> installer/data/mysql/en/mandatory/sample_notices.yml | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 3410210476..b070b6acf9 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -1364,7 +1364,6 @@ tables:
> message_transport_type: email
> lang: default
> content:
>- - "<html>"
> - "This email has been sent in response to your password recovery request for the account <<user>>."
> - ""
> - ""
>@@ -1373,8 +1372,6 @@ tables:
> - ""
> - "This link will be valid for 2 days from this email's reception, then you must reapply if you do not change your password."
> - "Thank you."
>- - "</html>"
>- - ""
> 
> - module: members
> code: STAFF_PASSWORD_RESET
>@@ -1385,7 +1382,6 @@ tables:
> message_transport_type: email
> lang: default
> content:
>- - "<html>"
> - "A librarian has reset the password for the account <<user>>."
> - ""
> - ""
>@@ -1394,8 +1390,6 @@ tables:
> - ""
> - "This link will be valid for 5 days from this email's reception, then you must reapply if you do not change your password."
> - "Thank you."
>- - "</html>"
>- - ""
> 
> - module: members
> code: SHARE_ACCEPT
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35186: 158048 | 158054 | 158079