Attachment 15810 Details for Bug 9445 – Bug 9445 [Revised] Use DataTables in local use system preferences editor

[patch] Bug 9445 [Revised] Use DataTables in local use system preferences editor

Bug-9445-Revised-Use-DataTables-in-local-use-syste.patch (text/plain), 3.43 KB, created by Owen Leonard on 2013-03-01 19:46:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-03-01 19:46:23 UTC

Size: 3.43 KB

patch

obsolete

>From 13a90278e056c1d03f22badb9873681a81d38b3f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 22 Jan 2013 12:37:08 -0500
>Subject: [PATCH] Bug 9445 [Revised] Use DataTables in local use system
> preferences editor
>Content-Type: text/plain; charset="utf-8"
>
>Replace the tablesorter plugin with the DataTables plugin in the
>local use system preferences editor.
>
>This patch moves embedding of the toolbar and table-sorting JS from
>within the body of the page to the <head> for sake of consistency.
>
>To test, open the system preferences editor to the Local Use tab.
>Confirm that table sorting works correctly. In this configuration there
>should be no pager and no results filtering.
>
>Revision corrects template path to datatables assets.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Comment: Tab sorting works. No errors.
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>
>Further revision removes old tablesorter code
>---
> .../prog/en/modules/admin/systempreferences.tt     |   30 ++++++++++++--------
> 1 file changed, 18 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>index 51e7b8e..c26cbd8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt
>@@ -2,6 +2,24 @@
> <title>Koha &rsaquo; Administration &rsaquo; [% IF ( add_form ) %] System preferences &rsaquo; [% IF ( modify ) %]Modify system preference '[% searchfield %]'[% ELSE %]Add a system preference[% END %][% END %][% IF ( add_validate ) %] System preferences &rsaquo; Data added[% END %]
> [% IF ( delete_confirm ) %] System preferences &rsaquo; [% searchfield %] &rsaquo; Confirm deletion of parameter '[% searchfield %]'[% END %][% IF ( delete_confirmed ) %] System preferences &rsaquo; Parameter deleted[% END %][% IF ( else ) %]System preferences[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>+[% IF ( else ) %]
>+<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
>+<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script>
>+[% INCLUDE 'datatables-strings.inc' %]
>+<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script>
>+<script type="text/javascript">
>+    //<![CDATA[
>+     $(document).ready(function() {
>+        [% IF ( loop ) %]$("#sysprefst").dataTable($.extend(true, {}, dataTablesDefaults, {
>+            "sDom": 't',
>+            "aoColumnDefs": [
>+                { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false, "bSearchable": false }
>+            ],
>+            "bPaginate": false
>+        }));[% END %]
>+     });
>+</script>
>+[% END %]
> <script type="text/javascript">
> //<![CDATA[
> [% IF ( add_form ) %]
>@@ -73,18 +91,6 @@
> 
>         //]]>
> </script>
>-[% IF ( else ) %]
>-    <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script>
>-    <script type="text/javascript">
>-    //<![CDATA[
>-     $(document).ready(function() {
>-        [% IF ( loop ) %]$("#sysprefst").tablesorter({
>-            sortList: [[0,0]],
>-            headers: { 1: {sorter:false},2: { sorter: false },3: { sorter: false },4: { sorter: false }}
>-        });[% END %]
>-     });
>-    </script>
>-[% END %]
> </head>
> <body id="admin_systempreferences" class="admin">
> [% INCLUDE 'header.inc' %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9445: 14755 | 14771 | 15700 | 15744 | 15775 | 15810