Attachment 158107 Details for Bug 34456 – Bug 34456: (QA follow-up) perltidy code

[patch] Bug 34456: (QA follow-up) perltidy code

Bug-34456-QA-follow-up-perltidy-code.patch (text/plain), 1.86 KB, created by Katrin Fischer on 2023-10-30 20:28:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-10-30 20:28:42 UTC

Size: 1.86 KB

patch

obsolete

>From 1f5548da341d27da8db369cda0faac18a77c4f9c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 30 Oct 2023 13:31:47 -0400
>Subject: [PATCH] Bug 34456: (QA follow-up) perltidy code
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> reports/guided_reports.pl | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index c3c104aaf2..85b42c4efb 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -990,11 +990,24 @@ elsif ($phase eq 'Export'){
>                 unlink $ods_filepath;
>             }
>             elsif ( $format eq 'template' ) {
>-                my $template_id = $input->param('template');
>+                my $template_id     = $input->param('template');
>                 my $notice_template = Koha::Notice::Templates->find($template_id);
>-                my $data = $sth->fetchall_arrayref({});
>-                $content = process_tt( $notice_template->content, { data => $data, report_id => $report_id, for_download => 1 } );
>-                $reportfilename = process_tt( $notice_template->title, { data => $data, report_id => $report_id } );
>+                my $data            = $sth->fetchall_arrayref( {} );
>+                $content = process_tt(
>+                    $notice_template->content,
>+                    {
>+                        data         => $data,
>+                        report_id    => $report_id,
>+                        for_download => 1,
>+                    }
>+                );
>+                $reportfilename = process_tt(
>+                    $notice_template->title,
>+                    {
>+                        data      => $data,
>+                        report_id => $report_id,
>+                    }
>+                );
>             }
>         }
>         print $input->header(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34456: 154156 | 154158 | 157924 | 157925 | 158092 | 158093 | 158094 | 158105 | 158106 | 158107