Attachment 158108 Details for Bug 28805 – Bug 28805: (follow-up) Fix template logic error

[patch] Bug 28805: (follow-up) Fix template logic error

Bug-28805-follow-up-Fix-template-logic-error.patch (text/plain), 1.78 KB, created by Fabricio Molina on 2023-10-30 20:54:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabricio Molina

Created: 2023-10-30 20:54:17 UTC

Size: 1.78 KB

patch

obsolete

>From 08bf441932d3737dab9c7b6492bbbd9d9b878d69 Mon Sep 17 00:00:00 2001
>From: Fabricio Molina <fabriciomolina@theke.io>
>Date: Mon, 30 Oct 2023 17:50:00 -0300
>Subject: [PATCH] Bug 28805: (follow-up) Fix template logic error
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch fixes a problem in the template logic that made the 'Due
>date' legend display when `OnSiteCheckouts` and `SpecifyDueDate` are not
>set, as highlighted by QA.
>
>Sponsored-by: Banco Central de la RepÃºblica Argentina
>---
> .../prog/en/modules/circ/circulation_batch_checkouts.tt       | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>index a2324ca5d7..59ab59ee68 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>@@ -100,10 +100,11 @@
>           </li>
>         </ol>
>       </fieldset>
>+      [% IF Koha.Preference('SpecifyDueDate') ||Â Koha.Preference('OnSiteCheckouts') %]
>       <fieldset class="rows">
>-          <legend>Due date</legend>
>           <ol>
>           [% IF Koha.Preference('SpecifyDueDate') %]
>+          <legend>Due date</legend>
>             <li>
>               <label for="duedatespec">Hard due date: [% INCLUDE 'date-format.inc' %]</label>
>               <input type="text" size="20" id="duedatespec" name="duedatespec" value="[% duedatespec | html %]" class="flatpickr" data-flatpickr-enable-time="true"/>
>@@ -119,6 +120,7 @@
>           [% END %]
>           </ol>
>       </fieldset>
>+      [% END %]
> 
>       <input type="hidden" name="op" value="show" />
>     </fieldset>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 28805: 152992 | 153105 | 153185 | 154346 | 156182 | 156183 | 156184 | 158108 | 158279 | 158386