Attachment 158176 Details for Bug 35198 – Bug 35198: Sort database column names alphabetically on automatic item modification page

[patch] Bug 35198: Sort database column names alphabetically on automatic item modification page

Bug-35198-Sort-database-column-names-alphabeticall.patch (text/plain), 4.52 KB, created by PTFS Europe Sandboxes on 2023-11-01 12:24:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2023-11-01 12:24:38 UTC

Size: 4.52 KB

patch

obsolete

>From 734b58431ed1cbf8bc1d5d658073e1c2d243f690 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 31 Oct 2023 13:48:11 +0000
>Subject: [PATCH] Bug 35198: Sort database column names alphabetically on
> automatic item modification page
>
>This patch modifies the automatic item modification by age page so that
>the rule entry form sorts <select>s alphabetically, making it easier to
>find the entry you need.
>
>The [% FOR field IN... %] directives now include the "sort" method, e.g.
>
>    [% FOR field IN agefields.sort %]
>
>To test, apply the patch and go to Cataloging -> Item modifications by
>age
>
>- Click the "Add rules" button, then the "Add rule" button.
>- Check the "Age field," "Conditions," and "Substitutions" dropdowns to
>  confirm that the choices are listed alphabetically.
>- Fill in the form and save the rule.
>- Go back and edit the rule you created. Check that the dropdowns are
>  still correct.
>
>Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
>---
> .../tools/automatic_item_modification_by_age.tt      | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>index 22683cef3b..1c1fc59f22 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt
>@@ -89,7 +89,7 @@
>                           <div class="blocks">
>                               <select name="agefield_[% id | html %]">
>                                   <option value="">Choose an age field</option>
>-                                  [% FOR field IN agefields %]
>+                                  [% FOR field IN agefields.sort %]
>                                     [% IF rule.agefield == field %]
>                                      <option value="[% field | html %]" selected="selected">[% field | html %]</option>
>                                     [% ELSE %]
>@@ -106,7 +106,7 @@
>                         <div class="block">
>                           <select name="condition_field_[% id | html %]">
>                             <option value="">Choose a field name</option>
>-                            [% FOR field IN condition_fields %]
>+                            [% FOR field IN condition_fields.sort %]
>                               [% IF condition.field == field %]
>                                 <option value="[% field | html %]" selected="selected">[% field | html %]</option>
>                               [% ELSE %]
>@@ -127,7 +127,7 @@
>                         <div class="block">
>                           <select class="required" required="required" name="substitution_field_[% id | html %]">
>                             <option value="">Choose a field name</option>
>-                            [% FOR field IN substitution_fields %]
>+                            [% FOR field IN substitution_fields.sort %]
>                               [% IF substitution.field == field %]
>                                 <option value="[% field | html %]" selected="selected">[% field | html %]</option>
>                               [% ELSE %]
>@@ -164,7 +164,7 @@
>               <div class="block">
>                   <select name="agefield">
>                       <option value="">Choose an age field</option>
>-                      [% FOR field IN agefields %]
>+                      [% FOR field IN agefields.sort %]
>                            <option value="[% field | html %]">[% field | html %]</option>
>                       [% END %]
>                   </select>
>@@ -176,7 +176,7 @@
>               <div class="block">
>                 <select name="condition_field">
>                   <option value="">Choose a field name</option>
>-                  [% FOR field IN condition_fields %]
>+                  [% FOR field IN condition_fields.sort %]
>                     <option value="[% field | html %]">[% field | html %]</option>
>                   [% END %]
>                 </select>
>@@ -191,7 +191,7 @@
>               <div class="block">
>                 <select required="required" class="required" name="substitution_field">
>                   <option value="">Choose a field name</option>
>-                  [% FOR field IN substitution_fields %]
>+                  [% FOR field IN substitution_fields.sort %]
>                     <option value="[% field | html %]">[% field | html %]</option>
>                   [% END %]
>                 </select>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35198: 158120 | 158176 | 158225