Attachment 158200 Details for Bug 33390 – Bug 33390: Add links to various system preference descriptions

[patch] Bug 33390: Add links to various system preference descriptions

Bug-33390-Add-links-to-various-system-preference-d.patch (text/plain), 10.96 KB, created by Katrin Fischer on 2023-11-01 18:09:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-01 18:09:11 UTC

Size: 10.96 KB

patch

obsolete

>From bcc6bcbbedcc53af000d268daa483448545e8e11 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 3 Apr 2023 21:09:51 +0000
>Subject: [PATCH] Bug 33390: Add links to various system preference
> descriptions
>
>To test:
>1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:
>
>DefaultLongOverdueChargeValue
>DefaultLongOverdueLostValue and DefaultLongOverdueDays
>DefaultLongOverdueSkipLostStatuses
>UpdateItemWhenLostFromHoldList
>
>NewItemsDefaultLocation
>UpdateItemLocationOnCheckin
>
>SkipHoldTrapOnNotForLoanValue
>UpdateNotForLoanStatusOnCheckin
>Reference_NFL_Statuses
>
>ItemsDeniedRenewal
>
>Signed-off-by: Catrina <catrina@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../admin/preferences/cataloguing.pref | 2 +-
> .../admin/preferences/circulation.pref | 38 +++++++++----------
> .../en/modules/admin/preferences/opac.pref | 2 +-
> 3 files changed, 20 insertions(+), 22 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>index 5a6346ed46..814ce6a904 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>@@ -125,7 +125,7 @@ Cataloging:
> - When items are created, give them the temporary location of
> - pref: NewItemsDefaultLocation
> class: short
>- - (should be a location code, or blank to disable).
>+ - (should be a <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOC">location code</a>, or blank to disable).
> -
> - pref: z3950NormalizeAuthor
> choices:
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 5cb207d3f0..d7192ba99f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -419,7 +419,7 @@ Circulation:
> 0: "don't ask"
> - "for confirmation."
> -
>- - By default, set the LOST value of an item to
>+ - By default, set the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> value of an item to
> - pref: DefaultLongOverdueLostValue
> choices: authval
> source: LOST
>@@ -428,11 +428,11 @@ Circulation:
> class: integer
> - days.
> - WARNING â These preferences will activate the automatic item loss process. Leave these fields empty if you don't want to activate this feature.
>- - " Example: [1] [30] Sets an item to the LOST value 1 when it has been overdue for more than 30 days."
>+ - " Example: [1] [30] Sets an item to the <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST'>LOST</a> value 1 when it has been overdue for more than 30 days."
> - (Used when the longoverdue.pl script is called without the --lost parameter)
> - " NOTE: This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
> -
>- - "Charge a lost item to the patron's account when the LOST value of the item changes to:"
>+ - "Charge a lost item to the patron's account when the <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST'>LOST</a> value of the item changes to:"
> - pref: DefaultLongOverdueChargeValue
> choices: authval
> source: LOST
>@@ -440,10 +440,10 @@ Circulation:
> - (Used when the longoverdue.pl script is called without the --charge parameter)
> - " NOTE: This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
> -
>- - When using the automatic item loss process, skip items with lost values matching any of
>+ - When using the automatic item loss process, skip items with <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> values matching any of
> - pref: DefaultLongOverdueSkipLostStatuses
> - "."
>- - Leave this field empty if you don't want to skip any lost statuses.
>+ - Leave this field empty if you don't want to skip any <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> statuses.
> - Set to a list of comma separated values, e.g. 5,6,7.
> -
> - "When issuing an item that has been marked as lost, "
>@@ -542,9 +542,9 @@ Circulation:
> - " Can name any field in the items table followed by a colon then a space then"
> - "a bracketed list of values separated by commas."
> - "For example:"
>- - " ccode: [NEWFIC,null,DVD]"
>- - " itype: [NEWBK,\"\"]"
>- - " NOTE: The word 'null' can be used to block renewal on undefined fields, while an empty string \"\" will block on an empty (but defined) field."
>+ - " ccode: [NEWFIC,NULL,DVD] <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=CCODE'>Collection codes</a>"
>+ - " itype: [NEWBK,\"\"] <a href='/cgi-bin/koha/admin/itemtypes.pl'>Item types</a>"
>+ - " NOTE: The word 'NULL' can be used to block renewal on undefined fields, while an empty string \"\" will block on an empty (but defined) field."
> -
> - pref: UpdateNotForLoanStatusOnCheckout
> type: textarea
>@@ -561,11 +561,11 @@ Circulation:
> 0: "Don't trap"
> - items that are not for loan but holdable ( notforloan < 0 ) to fill holds.
> -
>- - Never trap items with 'not for loan' values of
>+ - Never trap items with <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">'not for loan'</a> values of
> - pref: SkipHoldTrapOnNotForLoanValue
> class: integer
> - to fill holds.
>- - "(list of not for loan values separated with a pipe '|')"
>+ - "(list of <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN'>not for loan</a> values separated with a pipe '|')"
> -
> - pref: HoldsAutoFill
> choices:
>@@ -616,6 +616,7 @@ Circulation:
> syntax: text/x-yaml
> class: code
> - "This is a list of value pairs. The first value is followed immediately by colon space then the second value. "
>+ - <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOC">Location codes</a> 
> - "Examples: "
> - "PROC: FIC - causes an item in the Processing Center location to be updated into the Fiction location on check in. "
> - "FIC: GEN - causes an item in the Fiction location to be updated into the General stacks location on check in. "
>@@ -632,14 +633,11 @@ Circulation:
> type: textarea
> syntax: text/x-yaml
> class: code
>- - "This is a list of item types and value pairs. "
>- - "Examples: "
>- - "_ALL_: "
>- - "&nbsp-1: 0 "
>- - "CR: "
>- - "&nbsp1: 0 "
>- - "When an item is checked in, if it's item type matches CR then when the value on the left (1) matches the items' not for loan value it will be updated to the value on the right. The special term _ALL_ is used on the left side of the colon (:) to affect all item types, this does not override all other rules "
>- - "Each item type needs to be defined on a separate line on the left side of the colon (:). Each pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space "
>+ - This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value
>+ - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan."
>+ - "Can be used for showing only the not for loan description. E.g. '-1: ONLYMESSAGE'."
>+ - "Each pair of values should be on a separate line. "
>+ - <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">Not for loan values</a>
> -
> - pref: HidePersonalPatronDetailOnCirculation
> choices:
>@@ -945,8 +943,8 @@ Circulation:
> allow_and_notify: "Allow to mark items as lost and notify the patron"
> - from the 'Holds to pull' page. Values to be applied must be defined in <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UpdateItemWhenLostFromHoldList">UpdateItemWhenLostFromHoldList</a>.
> -
>- - A list of values to update an item's values with when it is marked as lost from the 'Holds to pull' page.
>- - 'Example: "itemlost: 1" to set items.itemlost to 1 when the item is marked as lost. (Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CanMarkHoldsToPullAsLost">CanMarkHoldsToPullAsLost</a>)'
>+ - A list of values to update an item's values with when it is marked as <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> from the 'Holds to pull' page.
>+ - 'Example: "itemlost: 1" to set items.itemlost to 1 when the item is marked as <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a>. (Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CanMarkHoldsToPullAsLost">CanMarkHoldsToPullAsLost</a>)'
> - pref: UpdateItemWhenLostFromHoldList
> type: textarea
> syntax: text/x-yaml
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 39815ecf72..b7d049f18e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -324,7 +324,7 @@ OPAC:
> footer: "only footer"
> - "."
> -
>- - "List the following not for loan statuses as available for reference in OPAC search results:"
>+ - "List the following <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN'>not for loan</a> statuses as available for reference in OPAC search results:"
> - pref: Reference_NFL_Statuses
> - "(Use | as delimiter.)"
> -
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33390: 149109 | 149110 | 150178 | 150909 | 150910 | 150911 | 158191 | 158192 | 158193 | 158200 | 158201 | 158202