Bugzilla – Attachment 158227 Details for
Bug 35205
Fix duplicate id attribute in desks search form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35205: Fix duplicate id attribute in desks search form
Bug-35205-Fix-duplicate-id-attribute-in-desks-sear.patch (text/plain), 2.33 KB, created by
David Nind
on 2023-11-01 23:11:18 UTC
(
hide
)
Description:
Bug 35205: Fix duplicate id attribute in desks search form
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-11-01 23:11:18 UTC
Size:
2.33 KB
patch
obsolete
>From 506f35e8b4c519bc3ca50b296c78d81f0415913a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 31 Oct 2023 16:58:48 +0000 >Subject: [PATCH] Bug 35205: Fix duplicate id attribute in desks search form > >This patch updates the header search form for desks administration so >that it doesn't contain an HTML id attribute which duplicates one on the >desks entry form. > >To test, apply the patch and make sure the "UseCirculationDesks" system >preference is enabled. > >- Go to Administration -> Circulation desks -> New desk. >- Click the "Desk" label in the entry form. Cursor focus should move to > the adjacent input field. >- Click the "Search desks" label in the header search form to confirm > that your cursor moves to the header search form. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/en/includes/desks-admin-search.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc >index 53d15e7dd4..4d017c588c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc >@@ -5,11 +5,11 @@ > <div id="desk_search" role="tabpanel" class="tab-pane active"> > <form action="[% script_name|html %]" method="post"> > <div class="form-title"> >- <label class="control-label" for="desk_name"><span class="control-text">Search desks</span> <i class="fa fa-fw fa-desktop" aria-hidden="true"></i></label> >+ <label class="control-label" for="search_desk_name"><span class="control-text">Search desks</span> <i class="fa fa-fw fa-desktop" aria-hidden="true"></i></label> > </div> > > <div class="form-content"> >- <input class="head-searchbox form-control" type="text" name="desk_name" placeholder="Search desks" id="desk_name" value="[% searchfield|html %]" size="40" /> >+ <input class="head-searchbox form-control" type="text" name="desk_name" placeholder="Search desks" id="search_desk_name" value="[% searchfield|html %]" size="40" /> > </div> > > <button type="submit" aria-label="Search"><i class="fa fa-arrow-right"></i></button> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35205
:
158144
|
158227
|
158391