Attachment 158228 Details for Bug 35212 – Bug 35212: Correct mismatched label on identity provider entry form

[patch] Bug 35212: Correct mismatched label on identity provider entry form

Bug-35212-Correct-mismatched-label-on-identity-pro.patch (text/plain), 1.71 KB, created by David Nind on 2023-11-01 23:35:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-11-01 23:35:21 UTC

Size: 1.71 KB

patch

obsolete

>From 5e79a34fd25c5a44b8dd7b523d47033d71a90478 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 1 Nov 2023 10:21:41 +0000
>Subject: [PATCH] Bug 35212: Correct mismatched label on identity provider
> entry form
>
>This patch corrects the identity provider form so that the label for the
>"Allow staff" field has the correct "for" attribute. Currently it is a
>duplicate of the one for the "Allow OPAC" field.
>
>To test, apply the patch and go to Administration -> Identity providers.
>
>- Click "New identity provider"
>- Near the bottom of the form, look for the "Allow staff" field.
>- Clicking the "Allow staff" label should activate the corresponding
>  dropdown.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/identity_providers.tt   | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
>index 239c116693..b6b4470563 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt
>@@ -199,7 +199,7 @@
>                         <div class="hint">Allow OPAC access to users from this domain to login with this identity provider.</div>
>                     </li>
>                     <li>
>-                        <label for="allow_opac">Allow staff: </label>
>+                        <label for="allow_staff">Allow staff: </label>
>                         <select name="allow_staff" id="allow_staff">
>                             <option value="1">Yes</option>
>                             <option value="0" selected="selected">No</option>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35212: 158167 | 158228 | 158392