Bugzilla – Attachment 158238 Details for
Bug 20755
Allow separate email configuration for acquisition and serials emails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20755: (QA follow-up) Add descriptions to system preferences
Bug-20755-QA-follow-up-Add-descriptions-to-system-.patch (text/plain), 5.57 KB, created by
Katrin Fischer
on 2023-11-02 09:42:44 UTC
(
hide
)
Description:
Bug 20755: (QA follow-up) Add descriptions to system preferences
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-02 09:42:44 UTC
Size:
5.57 KB
patch
obsolete
>From cd65dca46d57228e6e4ed1ad40e595c63ac37048 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Wed, 25 Oct 2023 09:39:30 +0000 >Subject: [PATCH] Bug 20755: (QA follow-up) Add descriptions to system > preferences > >Updates both the atomic update file and the sysprefs.sql with >* explanations for each preference >* type = "Free" >--- > ...g_20755-add_acquisitionsdefaultemailaddress_syspref.pl | 8 ++++---- > installer/data/mysql/mandatory/sysprefs.sql | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl b/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl >index a4f8eb0bbf1..394f9f291fd 100755 >--- a/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl >+++ b/installer/data/mysql/atomicupdate/bug_20755-add_acquisitionsdefaultemailaddress_syspref.pl >@@ -9,28 +9,28 @@ return { > > $dbh->do( > q{ >- INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultEMailAddress', '', NULL, NULL, NULL); >+ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultEMailAddress', '', NULL, "Default email address that acquisition notices are sent from.", 'Free'); > } > ); > say $out "Added new system preference 'AcquisitionsDefaultEMailAddress'"; > > $dbh->do( > q{ >- INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultReplyTo', '', NULL, NULL, NULL); >+ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('AcquisitionsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the acquisitions module.", 'Free'); > } > ); > say $out "Added new system preference 'AcquisitionsDefaultReplyTo'"; > > $dbh->do( > q{ >- INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultEMailAddress', '', NULL, NULL, NULL); >+ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultEMailAddress', '', NULL, "Default email address that serials notices are sent from.", 'Free'); > } > ); > say $out "Added new system preference 'SerialsDefaultEMailAddress'"; > > $dbh->do( > q{ >- INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultReplyTo', '', NULL, NULL, NULL); >+ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SerialsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the serials module.", 'Free'); > } > ); > say $out "Added new system preference 'SerialsDefaultReplyTo'"; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index afa78c5f118..6a56e875926 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -7,8 +7,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AcqItemSetSubfieldsWhenReceived','','','Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar")','Free'), > ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'), > ('AcquisitionLog','0',NULL,'If ON, log acquisitions activity','YesNo'), >-('AcquisitionsDefaultEMailAddress', '', NULL, NULL, NULL), >-('AcquisitionsDefaultReplyTo', '', NULL, NULL, NULL), >+('AcquisitionsDefaultEMailAddress', '', NULL, 'Default email address that acquisition notices are sent from', 'Free'), >+('AcquisitionsDefaultReplyTo', '', NULL, "Default email address used as reply-to for notices sent by the acquisitions module.", 'Free'), > ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: their own only, any within their branch, or all','Choice'), > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), > ('ActionLogsTraceDepth', '0', '', 'Sets the maximum depth of the action logs stack trace', 'Integer'), >@@ -677,8 +677,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), > ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), > ('SerialsSearchResultsLimit', NULL, NULL, 'Serials search results limit', 'integer'), >-('SerialsDefaultEMailAddress', '', NULL, NULL, NULL), >-('SerialsDefaultReplyTo', '', NULL, NULL, NULL), >+('SerialsDefaultEMailAddress', '', NULL, 'Default email address used as reply-to for notices sent by the serials module.', 'Free'), >+('SerialsDefaultReplyTo', '', NULL, 'Default email address that serials notices are sent from.', 'Free'), > ('SessionRestrictionByIP','1','Check for change in remote IP address for session security. Disable only when remote IP address changes frequently.','','YesNo'), > ('SessionStorage','mysql','mysql|Pg|tmp','Use database or a temporary file for storing session data','Choice'), > ('ShelfBrowserUsesCcode','1','0','Use the item collection code when finding items for the shelf browser.','YesNo'), >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20755
:
157191
|
157301
|
157747
|
157748
|
157749
|
157771
|
158235
|
158236
|
158237
| 158238