Bugzilla – Attachment 158275 Details for
Bug 25814
SIP: Add a message on successful checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25814: Tidy code
-Bug-25814-Tidy-code.patch (text/plain), 1.41 KB, created by
Kyle M Hall (khall)
on 2023-11-02 16:44:07 UTC
(
hide
)
Description:
Bug 25814: Tidy code
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-11-02 16:44:07 UTC
Size:
1.41 KB
patch
obsolete
>From 26f60d8429f930ac2bb686b458ccf7d32b6f01c5 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 2 Nov 2023 12:33:52 -0400 >Subject: [PATCH] Bug 25814: Tidy code > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/SIP/ILS.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 8c9314e7ec9..2184f13e1b2 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -264,14 +264,14 @@ sub checkin { > $patron->{items} = [ grep { $_ ne $item_id } @{ $patron->{items} } ]; > > my $message = ''; >- if ($account->{show_checkin_message}) { >+ if ( $account->{show_checkin_message} ) { > my $permanent_location; >- if (C4::Context->preference("UseLocationAsAQInSIP")) { >+ if ( C4::Context->preference("UseLocationAsAQInSIP") ) { > $permanent_location = $item->{'permanent_location'}; > } else { >- $permanent_location = Koha::Libraries->find($item->{permanent_location})->branchname; >+ $permanent_location = Koha::Libraries->find( $item->{permanent_location} )->branchname; > } >- $message .= "Item checked-in: " . $permanent_location . " - " . $item->{location} . "."; >+ $message .= "Item checked-in: $permanent_location - $item->{location}."; > } > > # Check for overdue fines to display >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25814
:
106058
|
154687
|
156142
|
158273
|
158274
| 158275