Attachment 158350 Details for Bug 34977 – Bug 34977: (QA follow-up) Tidy code

[patch] Bug 34977: (QA follow-up) Tidy code

Bug-34977-QA-follow-up-Tidy-code.patch (text/plain), 1.43 KB, created by Kyle M Hall (khall) on 2023-11-03 16:16:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-11-03 16:16:24 UTC

Size: 1.43 KB

patch

obsolete

>From 4d2487fdaed13a5eabf7af680f415035dd999d21 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 3 Nov 2023 12:10:42 -0400
>Subject: [PATCH] Bug 34977: (QA follow-up) Tidy code
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> patron_lists/delete.pl | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/patron_lists/delete.pl b/patron_lists/delete.pl
>index 56aa9ba2cad..e7c227ea1f7 100755
>--- a/patron_lists/delete.pl
>+++ b/patron_lists/delete.pl
>@@ -29,22 +29,22 @@ my $cgi = CGI->new;
> 
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>-        template_name   => "patron_lists/lists.tt",
>-        query           => $cgi,
>-        type            => "intranet",
>+        template_name => "patron_lists/lists.tt",
>+        query         => $cgi,
>+        type          => "intranet",
>         flagsrequired => { tools => 'manage_patron_lists' },
>     }
> );
> 
>-my $id = $cgi->param('patron_list_id');
>+my $id        = $cgi->param('patron_list_id');
> my @lists_ids = $cgi->multi_param('patron_lists_ids');
> 
>-if (defined $id && $id ne '') {
>-    DelPatronList({ patron_list_id => $id });
>+if ( defined $id && $id ne '' ) {
>+    DelPatronList( { patron_list_id => $id } );
> }
> if (@lists_ids) {
>     foreach my $list_id (@lists_ids) {
>-        DelPatronList({ patron_list_id => $list_id });
>+        DelPatronList( { patron_list_id => $list_id } );
>     }
> }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34977: 156553 | 156554 | 156562 | 158349 | 158350 | 159483 | 159484