Bugzilla – Attachment 158358 Details for
Bug 29002
Add ability to book items ahead of time
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29002: (follow-up) Make CanBook more resilient
Bug-29002-follow-up-Make-CanBook-more-resilient.patch (text/plain), 878 bytes, created by
Martin Renvoize (ashimema)
on 2023-11-03 17:13:03 UTC
(
hide
)
Description:
Bug 29002: (follow-up) Make CanBook more resilient
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-11-03 17:13:03 UTC
Size:
878 bytes
patch
obsolete
>From 88a1b417775bcff7aaee8e9e3fefe2720bcf2cc8 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 3 Nov 2023 17:11:51 +0000 >Subject: [PATCH] Bug 29002: (follow-up) Make CanBook more resilient > >This patch adds a check for biblio existance prior to method resolution >failure in Koha::Template::Plugin::Biblio. > >This fixes a failure case in unit tests. >--- > Koha/Template/Plugin/Biblio.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Template/Plugin/Biblio.pm b/Koha/Template/Plugin/Biblio.pm >index fb1193065f1..79c7284292f 100644 >--- a/Koha/Template/Plugin/Biblio.pm >+++ b/Koha/Template/Plugin/Biblio.pm >@@ -72,6 +72,7 @@ sub CanBook { > my ( $self, $biblionumber ) = @_; > > my $biblio = Koha::Biblios->find($biblionumber); >+ return 0 unless $biblio; > return $biblio->bookable_items->count ? 1 : 0; > } > >-- >2.41.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=158358">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29002
:
125456
|
125457
|
125458
|
125459
|
151209
|
151211
|
151213
|
151216
|
151217
|
151218
|
158357
| 158358 |
160831