Attachment 15836 Details for Bug 9722 – Bug 9722: Toggle display of hold notes with Edit notes button

[patch] Bug 9722: Toggle display of hold notes with Edit notes button

Bug-9722-Toggle-display-of-hold-notes-with-Edit-no.patch (text/plain), 2.02 KB, created by Marcel de Rooy on 2013-03-04 07:17:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2013-03-04 07:17:42 UTC

Size: 2.02 KB

patch

obsolete

>From 08d0ce42959aac422d891e185e34ba53387701d9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 4 Mar 2013 08:12:15 +0100
>Subject: [PATCH] Bug 9722: Toggle display of hold notes with Edit notes
> button
>Content-Type: text/plain; charset="utf-8"
>
>Small adjustments, requested by Kyle:
>1) Rename Show notes button. It is called now: Edit notes.
>2) Do not hide all other notes fields. The Edit button now only toggles
>the corresponding hold notes field.
>---
> .../opac-tmpl/prog/en/modules/opac-reserve.tt      |   10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>index 6b09e2b..f5feb29 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>@@ -117,8 +117,12 @@
>     // Show or hide holds notes
>     $(".shownotes").click(function(){
>         biblioNum = suffixOf($(this).attr("id"), "_");
>-        $(".notesrow").hide();
>-        $("#notesrow_"+biblioNum).show();
>+        if( $("#notesrow_"+biblioNum).is(":visible") ) {
>+            $("#notesrow_"+biblioNum).hide();
>+        }
>+        else {
>+            $("#notesrow_"+biblioNum).show();
>+        }
>     });
> 
>     // When 'Place Hold' button is clicked
>@@ -360,7 +364,7 @@
>       <a href="#" style="font-size:85%;text-decoration:none;" onclick="document.getElementById('expiration_date_[% bibitemloo.biblionumber %]').value='';return false;">Clear date</a></p>
>     </td>[% END %]
> 
>-    [% IF ( OPACShowHoldNotes ) %][% IF ( bibitemloo.holdable ) %]<td><input type="button" id="shownotes_[% bibitemloo.biblionumber %]" class="shownotes" value="Show notes"/></td>[% END %][% END %]
>+    [% IF ( OPACShowHoldNotes ) %][% IF ( bibitemloo.holdable ) %]<td><input type="button" id="shownotes_[% bibitemloo.biblionumber %]" class="shownotes" value="Edit notes"/></td>[% END %][% END %]
> 
>                     [% IF ( bibitemloo.holdable ) %]
> 		    
>-- 
>1.7.7.6

Actions: View | Diff | Splinter Review

Attachments on bug 9722: 15752 | 15753 | 15806 | 15807 | 15808 | 15834 | 15836 | 17717 | 17718 | 17719 | 17726 | 18342 | 18343 | 18344