Attachment 158388 Details for Bug 17798 – Bug 17798: Add fieldset for 'Yes, check out (Y)'

[patch] Bug 17798: Add fieldset for 'Yes, check out (Y)'

Bug-17798-Add-fieldset-for-Yes-check-out-Y.patch (text/plain), 1.95 KB, created by Katrin Fischer on 2023-11-04 17:42:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-04 17:42:56 UTC

Size: 1.95 KB

patch

obsolete

>From 92eb968c62dae4a9ef489e8ff2c3a262fea284a2 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 2 Nov 2023 19:10:02 +0000
>Subject: [PATCH] Bug 17798: Add fieldset for 'Yes, check out (Y)'
>
>With the increased text, the buttons don't arrange neatly. Adding a
>fieldset around the options for 'Yes' mitigates this somewhat - it
>could do with a bit more styling, however, it also fixes bug 23953
>
>To test:
>Confirm the 'Yes' options are more clear that they only affect the yes
>button
>Confirm the other buttons arrange nicely
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 5b31196b06..6048d1a189 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -263,6 +263,7 @@
> 
>                             [% IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
>                                 <form method="post" action="/cgi-bin/koha/circ/circulation.pl" autocomplete="off">
>+                                    <fieldset>
>                                     <input type="hidden" name="restoreduedatespec" />
> 
>                                     [% IF (forceallow) %]<input type="hidden" name="forceallow" value="1">[% END %]
>@@ -363,6 +364,7 @@
> 
>                                     <input type="hidden" name="onsite_checkout" value="[% onsite_checkout | html %]" />
>                                     <input type="hidden" name="auto_renew" value="[% auto_renew | html %]" />
>+                                    </fieldset>
>                                 </form>
>                             [% END # /IF CAN_user_circulate_force_checkout or HIGHHOLDS %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 17798: 158281 | 158282 | 158330 | 158331 | 158332 | 158387 | 158388 | 158389