Attachment 158422 Details for Bug 34931 – Bug 34931: Remove fieldset/legend in favor of div/h3

[patch] Bug 34931: Remove fieldset/legend in favor of div/h3

Bug-34931-Remove-fieldsetlegend-in-favor-of-divh3.patch (text/plain), 3.15 KB, created by Katrin Fischer on 2023-11-05 00:44:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-05 00:44:58 UTC

Size: 3.15 KB

patch

obsolete

>From a798b3c5c97d05d54a43072b6a6f2d64b3525eb8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 12 Oct 2023 22:14:10 +0000
>Subject: [PATCH] Bug 34931: Remove fieldset/legend in favor of div/h3
>
>1. Create some PA_CLASS authorized values.
>2. Create some custom patron attributes and add them to the newly created PA_CLASS's.
>3.  Set CollapseFieldsPatronAddForm to collapse 'Additional attributes and identifiers'.
>4. Go to a new or existing patron record.
>5. At the top of the page click the checkbox for "Show collapsed fields:".
>6. Scroll down to that section and notice the PA_CLASS <legend> element is shown but not the individual patron attributes within that PA_CLASS.
>7. Apply patch
>8. Try again, the Additional attributes and identifiers fieldset should display properly.
>
>Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 007e101206..88df5fe58d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1554,8 +1554,8 @@ legend:hover {
>                                             [% FOREACH pa_loo IN patron_attributes %]
>                                                 <ol class="attributes_table">
>                                                     [% IF pa_loo.class %]
>-                                                        <fieldset id="aai_[% pa_loo.class | html %]">
>-                                                        <legend id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</legend>
>+                                                        <div id="aai_[% pa_loo.class | html %]">
>+                                                        <h3 id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</h3>
>                                                     [% END %]
>                                                     [% FOREACH patron_attribute IN pa_loo.items %]
>                                                         <li data-category_code="[% patron_attribute.category_code | html %]" data-pa_code="[% patron_attribute.code | replace('[^a-zA-Z0-9_-]', '') %]">
>@@ -1598,7 +1598,7 @@ legend:hover {
>                                                             [% IF patron_attribute.mandatory %]<span class="required">Required</span>[% END %]
>                                                         </li>
>                                                     [% END # /FOREACH patron_attribute %]
>-                                                    [% IF pa_loo.class %]</fieldset>[% END %]
>+                                                    [% IF pa_loo.class %]</div>[% END %]
>                                                 </ol>
>                                             [% END # /FOREACH pa_loo %]
>                                         </fieldset> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34931: 157003 | 157562 | 158422