Bugzilla – Attachment 158428 Details for
Bug 26916
Show searchable patron attributes in patron search dropdown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26916: Adjust unit tests
Bug-26916-Adjust-unit-tests.patch (text/plain), 2.04 KB, created by
Katrin Fischer
on 2023-11-05 01:19:13 UTC
(
hide
)
Description:
Bug 26916: Adjust unit tests
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-05 01:19:13 UTC
Size:
2.04 KB
patch
obsolete
>From e665d3d31659e0f12cca162978653e2f435c3c40 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 11 Aug 2023 17:40:28 +0000 >Subject: [PATCH] Bug 26916: Adjust unit tests > >Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/selenium/patrons_search.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t >index 7b8630ddb9..e34fa52952 100755 >--- a/t/db_dependent/selenium/patrons_search.t >+++ b/t/db_dependent/selenium/patrons_search.t >@@ -164,8 +164,9 @@ subtest 'Search patrons' => sub { > $s->auth; > C4::Context->set_preference('DefaultPatronSearchFields',""); > C4::Context->set_preference('DefaultPatronSearchMethod',"contains"); >+ my $searchable_attributes = Koha::Patron::Attribute::Types->search({ staff_searchable => 1 })->count(); > my $PatronsPerPage = 15; >- my $nb_standard_fields = 13; >+ my $nb_standard_fields = 13 + $searchable_attributes; # Standard fields, plus one searchable attribute > C4::Context->set_preference('PatronsPerPage', $PatronsPerPage); > $driver->get( $base_url . "/members/members-home.pl" ); > my @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option'); >@@ -182,7 +183,6 @@ subtest 'Search patrons' => sub { > @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option'); > is( scalar @filter_options, $nb_standard_fields, 'New filter option added when DefaultPatronSearchFields is populated with a field'); > is( $filter_options[0]->get_value(), 'standard', 'Standard filter uses value "standard"'); >- C4::Context->set_preference('DefaultPatronSearchFields',"firstname|initials|horses"); > $driver->get( $base_url . "/members/members-home.pl" ); > @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option'); > @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option'); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26916
:
154385
|
154386
|
154573
|
154574
|
154653
|
154654
|
158427
| 158428