Attachment 158433 Details for Bug 34517 – Bug 34517: (QA follow-up) Perltidy and fix column check

[patch] Bug 34517: (QA follow-up) Perltidy and fix column check

Bug-34517-QA-follow-up-Perltidy-and-fix-column-che.patch (text/plain), 1.98 KB, created by Katrin Fischer on 2023-11-05 01:21:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-05 01:21:21 UTC

Size: 1.98 KB

patch

obsolete

>From cddc3df0385b7993bbffd202c9862768528e82da Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 5 Nov 2023 01:14:52 +0000
>Subject: [PATCH] Bug 34517: (QA follow-up) Perltidy and fix column check
>
>Without the fix a second run of the database update would fail.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> ...7_add_searched_by_default_to_attribute_types.pl | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_34517_add_searched_by_default_to_attribute_types.pl b/installer/data/mysql/atomicupdate/bug_34517_add_searched_by_default_to_attribute_types.pl
>index 767f212513..b86f623367 100755
>--- a/installer/data/mysql/atomicupdate/bug_34517_add_searched_by_default_to_attribute_types.pl
>+++ b/installer/data/mysql/atomicupdate/bug_34517_add_searched_by_default_to_attribute_types.pl
>@@ -8,17 +8,21 @@ return {
>         my ( $dbh, $out ) = @$args{qw(dbh out)};
> 
>         # Do you stuffs here
>-        unless ( column_exists( 'borrower_attribute_type', 'searched_by_default' ) ) {
>-            $dbh->do(q{
>+        unless ( column_exists( 'borrower_attribute_types', 'searched_by_default' ) ) {
>+            $dbh->do(
>+                q{
>                 ALTER TABLE borrower_attribute_types
>                 ADD COLUMN `searched_by_default` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'defines if this field is included in "Standard" patron searches in the staff interface (1 for yes, 0 for no)'
>                 AFTER `staff_searchable`
>-            });
>+            }
>+            );
>             say $out "Added column 'borrower_attribute_types.searched_by_default'";
>-            $dbh->do(q{
>+            $dbh->do(
>+                q{
>                 UPDATE borrower_attribute_types
>                 SET searched_by_default = 1 WHERE staff_searchable = 1;
>-            });
>+            }
>+            );
>             say $out "Updated values to match staff_searchable columns";
>         }
>     },
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34517: 154389 | 154390 | 154391 | 154392 | 154575 | 154576 | 154577 | 154578 | 154608 | 154610 | 154611 | 154612 | 154613 | 154614 | 154615 | 154616 | 154617 | 154618 | 154619 | 154620 | 154622 | 154623 | 154624 | 154625 | 158429 | 158430 | 158431 | 158432 | 158433 | 158876 | 158878