Attachment 158459 Details for Bug 35245 – Bug 35245: Set default width for select2 in authorities

[patch] Bug 35245: Set default width for select2 in authorities

Bug-35245-Set-default-width-for-select2-in-authori.patch (text/plain), 2.15 KB, created by Katrin Fischer on 2023-11-05 11:43:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-05 11:43:39 UTC

Size: 2.15 KB

patch

obsolete

>From 2818dbd3cef2b7dc21f5af0fd88d2553eaaffb16 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 3 Nov 2023 10:17:23 +0000
>Subject: [PATCH] Bug 35245: Set default width for select2 in authorities
>
>Test plan:
>1) Edit a authority Marc framework, e.g. 'CHRON_TERM', visit:
>   /cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=CHRON_TERM
>2) Pick any field to turn into a AV field, e.g. 371, and edit its subfields:
>   /cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=371&authtypecode=CHRON_TERM
>3) Pick a subfield e.g. 'd' and click edit, visit:
>   /cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=371&tagsubfield=d&authtypecode=CHRON_TERM#subdfield
>4) Pick a Authorized value list e.g. DEPARTMENT, click Submit
>5) Create a new authority of the same type 'CHRON_TERM', visit:
>   /cgi-bin/koha/authorities/authorities.pl?authtypecode=CHRON_TERM
>6) Click on Tab '3' and click on field 371 ADDRESS to expand it
>7) Notice field 'd' select2 width is very narrow
>8) Apply patch. Repeat. Notice its not narrow anymore
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/authorities/authorities.tt   | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index cbae792256..9730ce3c46 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -14,14 +14,15 @@
> [% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% Asset.js("lib/hc-sticky.js") | $raw %]
>+[% INCLUDE 'select2.inc' %]
> <script>
>     [% IF Koha.Preference('CreateAVFromCataloguing') && CAN_user_parameters_manage_auth_values %]
>         var auth_values_creation = 1;
>     [% ELSE %]
>         var auth_values_creation = 0;
>     [% END %]
>+    $.fn.select2.defaults.set("width", "100%" );
> </script>
>-[% INCLUDE 'select2.inc' %]
> [% Asset.js( "lib/sortable/Sortable.min.js" ) | $raw %]
> [% Asset.js("js/cataloging.js") | $raw %]
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35245: 158319 | 158320 | 158459