Attachment 158460 Details for Bug 34993 – Bug 34993: Pass context parameters to generate_subfield_form

[patch] Bug 34993: Pass context parameters to generate_subfield_form

Bug-34993-Pass-context-parameters-to-generatesubfi.patch (text/plain), 3.79 KB, created by Katrin Fischer on 2023-11-05 11:58:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-05 11:58:27 UTC

Size: 3.79 KB

patch

obsolete

>From a8023641f45f65339fed74b6c55129db1818611e Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Thu, 2 Nov 2023 12:56:35 -0400
>Subject: [PATCH] Bug 34993: Pass context parameters to generate_subfield_form
>
>Pass necessary parameters from the UI to ensure that the basic
>MARC editor can correctly identify when a framework is changed,
>a bib is being duplicated, or a bib is being imported with Z39.50 -
>for purposes of filling in default values according to the settings
>of ApplyFrameworkDefaults.
>
>To test:
>1. Set the system preference ApplyFrameworkDefaults - Select All
>2. Create or edit a MARC bibliographic framework with a default value in
>   one of the fields (such as 500$a)
>3. Go to the Cataloguing module and create a new record using the
>   framework from step 2
>   --> Confirm that the default value is filled in
>4. Search for an existing bib record
>5. Click Edit > Edit record to open the basic editor
>6. If the field from step 2 already has data, clear it
>7. Switch the framework to the framework from step 2
>   --> Confirm that the default value is filled in
>8. Clear the field again, and save the edit
>9. Click Edit > Edit as new (duplicate)
>   --> Confirm that the default value is filled in
>10. Go to the cataloguing module and do a Z39.50 search
>11. Find a record that does not have a value for the subfield from step 2
>12. Import the record using the framework from step 2
>    --> Confirm that the default value is filled in
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> cataloguing/addbiblio.pl | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index a11711afd3..793a7e2c20 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -342,6 +342,9 @@ sub build_tabs {
>                                         index_tag => $index_tag,
>                                         record => $record,
>                                         hostitemnumber => scalar $input->param('hostitemnumber'),
>+                                        op => scalar $input->param('op'),
>+                                        changed_framework => scalar $input->param('changed_framework'),
>+                                        breedingid => scalar $input->param('breedingid'),
>                                         tagslib => $tagslib,
>                                         mandatory_z3950 => $mandatory_z3950,
>                                     }
>@@ -380,6 +383,9 @@ sub build_tabs {
>                                     index_tag => $index_tag,
>                                     record => $record,
>                                     hostitemnumber => scalar $input->param('hostitemnumber'),
>+                                    op => scalar $input->param('op'),
>+                                    changed_framework => scalar $input->param('changed_framework'),
>+                                    breedingid => scalar $input->param('breedingid'),
>                                     tagslib => $tagslib,
>                                     mandatory_z3950 => $mandatory_z3950,
>                                 }
>@@ -444,6 +450,9 @@ sub build_tabs {
>                                 index_tag => $index_tag,
>                                 record => $record,
>                                 hostitemnumber => scalar $input->param('hostitemnumber'),
>+                                op => scalar $input->param('op'),
>+                                changed_framework => scalar $input->param('changed_framework'),
>+                                breedingid => scalar $input->param('breedingid'),
>                                 tagslib => $tagslib,
>                                 mandatory_z3950 => $mandatory_z3950,
>                             }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34993: 158277 | 158287 | 158460 | 158461