Bugzilla – Attachment 158461 Details for
Bug 34993
Framework doesn't load defaults in existing records or duplicate as new
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34993: (QA follow-up) Perltidy
Bug-34993-QA-follow-up-Perltidy.patch (text/plain), 8.37 KB, created by
Katrin Fischer
on 2023-11-05 11:58:31 UTC
(
hide
)
Description:
Bug 34993: (QA follow-up) Perltidy
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-05 11:58:31 UTC
Size:
8.37 KB
patch
obsolete
>From 589383dc0a093a8137660ea0bf26e3fba6177fdd Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 5 Nov 2023 11:50:17 +0000 >Subject: [PATCH] Bug 34993: (QA follow-up) Perltidy > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > cataloguing/addbiblio.pl | 96 ++++++++++++++++++++-------------------- > 1 file changed, 48 insertions(+), 48 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index 793a7e2c20..e84c542092 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -310,17 +310,17 @@ sub build_tabs { > @subfields_data, > $biblio_form_builder->generate_subfield_form( > { >- tag => $tag, >- subfield => $subfield, >- value => $value, >- index_tag => $index_tag, >- record => $record, >- hostitemnumber => scalar $input->param('hostitemnumber'), >- op => scalar $input->param('op'), >+ tag => $tag, >+ subfield => $subfield, >+ value => $value, >+ index_tag => $index_tag, >+ record => $record, >+ hostitemnumber => scalar $input->param('hostitemnumber'), >+ op => scalar $input->param('op'), > changed_framework => scalar $input->param('changed_framework'), >- breedingid => scalar $input->param('breedingid'), >- tagslib => $tagslib, >- mandatory_z3950 => $mandatory_z3950, >+ breedingid => scalar $input->param('breedingid'), >+ tagslib => $tagslib, >+ mandatory_z3950 => $mandatory_z3950, > } > ) > ); >@@ -336,17 +336,17 @@ sub build_tabs { > @subfields_data, > $biblio_form_builder->generate_subfield_form( > { >- tag => $tag, >- subfield => $subfield, >- value => $value, >- index_tag => $index_tag, >- record => $record, >- hostitemnumber => scalar $input->param('hostitemnumber'), >- op => scalar $input->param('op'), >+ tag => $tag, >+ subfield => $subfield, >+ value => $value, >+ index_tag => $index_tag, >+ record => $record, >+ hostitemnumber => scalar $input->param('hostitemnumber'), >+ op => scalar $input->param('op'), > changed_framework => scalar $input->param('changed_framework'), >- breedingid => scalar $input->param('breedingid'), >- tagslib => $tagslib, >- mandatory_z3950 => $mandatory_z3950, >+ breedingid => scalar $input->param('breedingid'), >+ tagslib => $tagslib, >+ mandatory_z3950 => $mandatory_z3950, > } > ) > ); >@@ -377,17 +377,17 @@ sub build_tabs { > @subfields_data, > $biblio_form_builder->generate_subfield_form( > { >- tag => $tag, >- subfield => $subfield, >- value => '', >- index_tag => $index_tag, >- record => $record, >- hostitemnumber => scalar $input->param('hostitemnumber'), >- op => scalar $input->param('op'), >+ tag => $tag, >+ subfield => $subfield, >+ value => '', >+ index_tag => $index_tag, >+ record => $record, >+ hostitemnumber => scalar $input->param('hostitemnumber'), >+ op => scalar $input->param('op'), > changed_framework => scalar $input->param('changed_framework'), >- breedingid => scalar $input->param('breedingid'), >- tagslib => $tagslib, >- mandatory_z3950 => $mandatory_z3950, >+ breedingid => scalar $input->param('breedingid'), >+ tagslib => $tagslib, >+ mandatory_z3950 => $mandatory_z3950, > } > ) > ); >@@ -440,24 +440,24 @@ sub build_tabs { > # always include in the form regardless of the hidden setting - bug 2206 and 28022 > next > if ( $subfield->{tab} ne $tabloop ); >- push( >- @subfields_data, >- $biblio_form_builder->generate_subfield_form( >- { >- tag => $tag, >- subfield => $subfield->{subfield}, >- value => '', >- index_tag => $index_tag, >- record => $record, >- hostitemnumber => scalar $input->param('hostitemnumber'), >- op => scalar $input->param('op'), >- changed_framework => scalar $input->param('changed_framework'), >- breedingid => scalar $input->param('breedingid'), >- tagslib => $tagslib, >- mandatory_z3950 => $mandatory_z3950, >- } >- ) >- ); >+ push( >+ @subfields_data, >+ $biblio_form_builder->generate_subfield_form( >+ { >+ tag => $tag, >+ subfield => $subfield->{subfield}, >+ value => '', >+ index_tag => $index_tag, >+ record => $record, >+ hostitemnumber => scalar $input->param('hostitemnumber'), >+ op => scalar $input->param('op'), >+ changed_framework => scalar $input->param('changed_framework'), >+ breedingid => scalar $input->param('breedingid'), >+ tagslib => $tagslib, >+ mandatory_z3950 => $mandatory_z3950, >+ } >+ ) >+ ); > } > if ( $#subfields_data >= 0 ) { > my %tag_data = ( >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34993
:
158277
|
158287
|
158460
| 158461