Attachment 158494 Details for Bug 35264 – Bug 35264: Add "protected" column to patron import

[patch] Bug 35264: Add "protected" column to patron import

Bug-35264-Add-protected-column-to-patron-import.patch (text/plain), 2.37 KB, created by Martin Renvoize (ashimema) on 2023-11-06 09:41:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-11-06 09:41:18 UTC

Size: 2.37 KB

patch

obsolete

>From 88a96a08ce714df9c485b8eb66a61fec0b4b7043 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 6 Nov 2023 05:31:29 +0000
>Subject: [PATCH] Bug 35264: Add "protected" column to patron import
>
>This change adds the "protected" column to patron import.
>
>Test plan:
>0. Apply the patch and run "restart_all"
>1. prove -v t/db_dependent/Koha/Patrons/Import.t
>2. Go to http://localhost:8081/cgi-bin/koha/tools/import_borrowers.pl
>3. Note "protected" is listed in the "fields you want to supply"
>on the right side of the screen
>4. Note "protected" appears in file downloaded by clicking
>"Download a Starter CSV file with all the columns"
>5. Note that "Protected" appears after clicking "Enter default values"
>and after clicking "Preserve existing values"
>
>6. For bonus marks, use the "Starter CSV file" to import a test patron
>(remember surname, branchcode, and categorycode are the required fields)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Database/Columns.pm | 1 +
> Koha/Patrons/Import.pm   | 2 ++
> 2 files changed, 3 insertions(+)
>
>diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm
>index f5c45af5de1..4637d0cab3a 100644
>--- a/Koha/Database/Columns.pm
>+++ b/Koha/Database/Columns.pm
>@@ -180,6 +180,7 @@ sub columns {
>             "privacy_guarantor_fines"     => __("Show fines to guarantor"),
>             "privacy"                     => __("Privacy settings"),
>             "pronouns"                    => __("Pronouns"),
>+            "protected"                   => __("Protected"),
>             "relationship"                => __("Relationship"),
>             "secret"                      => __("Secret (2FA)"),
>             "sex"                         => __("Gender"),
>diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm
>index b1c751007e2..d6e0846cad2 100644
>--- a/Koha/Patrons/Import.pm
>+++ b/Koha/Patrons/Import.pm
>@@ -146,6 +146,8 @@ sub import_patrons {
>         $borrower{cardnumber} = undef if $borrower{cardnumber} eq "";
>         $borrower{auth_method} = undef if $borrower{auth_method} eq "";
> 
>+        $borrower{protected} = 0 unless $borrower{protected};
>+
>         # Check if borrower category code exists and if it matches to a known category. Pushing error to missing_criticals otherwise.
>         $self->check_borrower_category($borrower{categorycode}, $borrowerline, $line_number, \@missing_criticals);
> 
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 35264: 158486 | 158494