Attachment 158557 Details for Bug 34375 – Bug 34375: Fix the option to provide no fund in budget dropdown

[patch] Bug 34375: Fix the option to provide no fund in budget dropdown

Bug-34375-Fix-the-option-to-provide-no-fund-in-bud.patch (text/plain), 1.86 KB, created by Katrin Fischer on 2023-11-06 19:56:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-06 19:56:39 UTC

Size: 1.86 KB

patch

obsolete

>From 6ac2264ca811ebffb4b3354374dcdf0ed3d892ca Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 6 Nov 2023 10:40:33 +0000
>Subject: [PATCH] Bug 34375: Fix the option to provide no fund in budget
> dropdown
>
>Currently it is not possible to use the No fund option as the dropwdown will default to the first budget in the list. This patch re-adds this option so that the defaulting behaviour is fixed
>
>Test plan:
>1) Go to a vendor record in Acquisitions and then Receive Shipment
>2) Enter an invoice number
>3) Leave the Shipping cost empty and Shipping Fund as 'No fund'
>4) Receive some orders or go straight to Finish receiving
>5) Notice the Shipping fund has defaulted to the first fund in the alphabetical list of funds.  It is not possible to select 'No fund' and the selected fund is recorded in shipmentcost_budgetid incorrectly.
>6) Apply patch
>7) Repeat steps 1-5 and this time the No fund option should be used correctly
>
>Signed-off-by: Georgia Newman <g.newman@arts.ac.uk>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index c45df84eb7..9610fdd88a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -524,6 +524,7 @@
> </div> 
> 
> <span style="display:none;" id="all_fund_dropdown">
>+    <option value="">No fund</option>
>     [% FOREACH budget IN budgets %]
>         [% IF ( budget.b_active ) %]
>             <option value="[% budget.b_id | html %]" data-sort1-authcat="[% budget.b_sort1_authcat | html %]" data-sort2-authcat="[% budget.b_sort2_authcat | html %]">[% budget.b_txt | html %]</option>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34375: 158266 | 158497 | 158513 | 158557