Bugzilla – Attachment 15856 Details for
Bug 8917
Track clicks to links external to Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature
Bug-8917--Follow-up-fixing-bad-behaviour-that-exis.patch (text/plain), 2.72 KB, created by
Jonathan Druart
on 2013-03-04 16:01:04 UTC
(
hide
)
Description:
Bug 8917 : Follow up fixing bad behaviour that existed prior to this feature
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-03-04 16:01:04 UTC
Size:
2.72 KB
patch
obsolete
>From 78b3df1f93a14c4134424f2e7d5f66df80204def Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Sat, 2 Mar 2013 10:09:22 +1300 >Subject: [PATCH] Bug 8917 : Follow up fixing bad behaviour that existed prior > to this feature > >But the bug only becomes visible with link tracking on >Prior to this patch it would put an empty link in the html > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >General comment: Work as described. No errors. >Tested all preference values with and without logged in user. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index ac5c0b7..04c0811 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -1489,14 +1489,15 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <td class="call_no">[% IF ( ITEM_RESULT.itemcallnumber ) %] [% ITEM_RESULT.itemcallnumber %][% IF ( OPACShelfBrowser ) %] (<a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber %]#[% tab %]">Browse shelf</a>)[% END %][% END %]</td> > [% IF ( itemdata_enumchron ) %]<td class="vol_info">[% ITEM_RESULT.enumchron %]</td>[% END %] > [% IF ( itemdata_uri ) %]<td class="url"> >- [% IF trackclicks == 'track' || trackclicks == 'anonymous' %] >- <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]"> Link to resource </a> >- [% ELSE %] >- <a href="[% ITEM_RESULT.uri %]">[% ITEM_RESULT.uri %]</a> >+ [% IF ITEM_RESULT.uri %] >+ [% IF trackclicks == 'track' || trackclicks == 'anonymous' %] >+ <a href="/cgi-bin/koha/tracklinks.pl?uri=[% ITEM_RESULT.uri | url %]&biblionumber=[% biblionumber |url %]&itemnumber=[% ITEM_RESULT.itemnumber | url %]"> Link to resource </a> >+ [% ELSE %] >+ <a href="[% ITEM_RESULT.uri %]">[% ITEM_RESULT.uri %]</a> >+ [% END %] > [% END %] > </td> > [% END %] >- [% IF ( itemdata_uri ) %]<td class="url"><a href="[% ITEM_RESULT.uri %]">[% ITEM_RESULT.uri %]</a></td>[% END %] > [% IF ( itemdata_copynumber ) %]<td class="copynumber">[% ITEM_RESULT.copynumber %]</td>[% END %] > <td class="status">[% INCLUDE 'item-status.inc' item = ITEM_RESULT %]</td> > [% IF ( itemdata_itemnotes ) %]<td class="notes">[% ITEM_RESULT.itemnotes %]</td>[% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8917
:
12831
|
12832
|
12833
|
12834
|
12998
|
12999
|
13000
|
13001
|
14058
|
14059
|
14060
|
14061
|
15669
|
15670
|
15671
|
15672
|
15711
|
15712
|
15713
|
15714
|
15715
|
15716
|
15783
|
15784
|
15785
|
15786
|
15787
|
15812
|
15815
|
15818
|
15819
|
15820
|
15821
|
15822
|
15823
|
15824
|
15825
|
15850
|
15851
|
15852
|
15853
|
15854
|
15855
| 15856 |
15857
|
15858