Bugzilla – Attachment 158575 Details for
Bug 21173
Add hours as age unit to auto item modifications by age for damaged_on, itemlost_on and withdrawn_on fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21173: (follow-up) Re-ordering input fields in item modification by age form
Bug-21173-follow-up-Re-ordering-input-fields-in-it.patch (text/plain), 6.09 KB, created by
Alex Buckley
on 2023-11-06 22:15:27 UTC
(
hide
)
Description:
Bug 21173: (follow-up) Re-ordering input fields in item modification by age form
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2023-11-06 22:15:27 UTC
Size:
6.09 KB
patch
obsolete
>From f1098e64b73e47b90c734e4a5b2c4742de03394f Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Mon, 6 Nov 2023 22:12:41 +0000 >Subject: [PATCH] Bug 21173: (follow-up) Re-ordering input fields in item > modification by age form > >Sponsored-by: Toi Ohomai Institute of Technology, New Zealand >--- > .../automatic_item_modification_by_age.tt | 59 +++++++++---------- > 1 file changed, 29 insertions(+), 30 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >index 54b0b2e1214..fcbfb9f4b25 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt >@@ -91,23 +91,6 @@ > <legend>Rule <span class="rulecount">[% loop.count | html %]</span> <a href="#" class="remove_rule"><i class="fa fa-trash-can"></i> Remove this rule</a></legend> > <input type="hidden" name="unique_id" value="[% loop.count | html %]" /> <!-- FIXME on update, the unique_id should be filled --> > <div class="age"> >- <h5>Age</h5> >- <input class="age" type="text" inputmode="numeric" pattern="[0-9]*" value="[% rule.age | html %]" name="age_[% id | html %]" /> >- <h5>Age unit</h5> >- <div class="block"> >- <select name="ageunit_[% id | html %]"> >- <option value="">Choose an age unit</option> >- [% FOR unit IN ageunits %] >- [% IF rule.ageunit == unit %] >- <option value="[% unit | html %]" selected="selected">[% unit | html %]</option> >- [% ELSE %] >- <option value="[% unit | html %]">[% unit | html %]</option> >- [% END %] >- [% END %] >- </select> >- <span class="hint">Only the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields can use the 'Hours unit. If not set then days will be used.</span> >- </div> >- > <h5>Age field</h5> > <div class="blocks"> > <select name="agefield_[% id | html %]" onchange="unit_display()"> >@@ -122,7 +105,23 @@ > </select> > <span class="hint">If not set then items.dateaccessioned will be used</span> > </div> >- </div> >+ </div> >+ <h5>Age unit</h5> >+ <div class="block"> >+ <select name="ageunit_[% id | html %]"> >+ <option value="">Choose an age unit</option> >+ [% FOR unit IN ageunits %] >+ [% IF rule.ageunit == unit %] >+ <option value="[% unit | html %]" selected="selected">[% unit | html %]</option> >+ [% ELSE %] >+ <option value="[% unit | html %]">[% unit | html %]</option> >+ [% END %] >+ [% END %] >+ </select> >+ <span class="hint">Only the items.damaged_on, items.itemlost_on and items.withdrawn_on age fields can use the 'Hours unit. If not set then days will be used.</span> >+ </div> >+ <h5>Age</h5> >+ <input class="age" type="text" inputmode="numeric" pattern="[0-9]*" value="[% rule.age | html %]" name="age_[% id | html %]" /> > <div class="blocks"> > <h5>Conditions</h5> > [% FOR condition IN rule.conditions %] >@@ -181,18 +180,6 @@ > <legend>Rule <span class="rulecount"></span> <a href="#" class="remove_rule"><i class="fa fa-trash-can"></i> Remove this rule</a></legend> > <input type="hidden" name="unique_id" /> > <div class="age"> >- <h5>Age</h5> >- <input class="age" type="text" inputmode="numeric" pattern="[0-9]*" value="" name="age" /> >- <h5>Age unit</h5> >- <div class="block"> >- <select name="ageunit"> >- <option value="">Choose an age unit</option> >- [% FOR unit IN ageunits %] >- <option value="[% unit | html %]">[% unit | html %]</option> >- [% END %] >- </select> >- <span class="hint">Only items.damaged_on, items.itemlost_on and items.withdrawn_on age fields can use the 'Hours' unit. If not set then days will be used.</span> >- </div> > <h5>Age field</h5> > <div class="block"> > <select name="agefield" onchange="unit_display()"> >@@ -204,6 +191,18 @@ > <span class="hint">If not set then items.dateaccessioned will be used</span> > </div> > </div> >+ <h5>Age unit</h5> >+ <div class="block"> >+ <select name="ageunit"> >+ <option value="">Choose an age unit</option> >+ [% FOR unit IN ageunits %] >+ <option value="[% unit | html %]">[% unit | html %]</option> >+ [% END %] >+ </select> >+ <span class="hint">Only items.damaged_on, items.itemlost_on and items.withdrawn_on age fields can use the 'Hours' unit. If not set then days will be used.</span> >+ </div> >+ <h5>Age</h5> >+ <input class="age" type="text" inputmode="numeric" pattern="[0-9]*" value="" name="age" /> > <div class="blocks"> > <h5>Conditions</h5> > <div class="block"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21173
:
77547
|
77548
|
77604
|
77605
|
78917
|
79914
|
138870
|
138871
|
138872
|
138894
|
138895
|
138896
|
156137
|
156138
|
156139
|
158574
|
158575
|
160715
|
160716