Attachment 158598 Details for Bug 34857 – Bug 34857 Do not enable hidden select element (regression from bug 33233).

[patch] Bug 34857 Do not enable hidden select element (regression from bug 33233).

Bug-34857-Do-not-enable-hidden-select-element-regr.patch (text/plain), 1.39 KB, created by Andreas Jonsson on 2023-11-07 13:52:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Jonsson

Created: 2023-11-07 13:52:31 UTC

Size: 1.39 KB

patch

obsolete

>From b43b6926f845629ed40478e9e94b00afbe6f116e Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Tue, 7 Nov 2023 14:42:58 +0100
>Subject: [PATCH] Bug 34857 Do not enable hidden select element (regression
> from bug 33233).
>
>Test plan:
>
>Using Chrome as web browser:
>
>* Go to opac advanced search
>* Press "more options"
>* Search for two keywords using "and" operator (on ktd search for idea AND behind, which matches 1 result)
>* Search for two keywords using "or" operator (on ktd search for idea OR behind, which matches 4 results)
>* Search for two keywords using "not" operator (on ktd search for idea NOT behind, which matches 2 results)
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>index eb1edd78bc..697f978c3a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>@@ -458,7 +458,7 @@
> [% Asset.js("lib/jquery/plugins/jquery.deserialize.min.js") | $raw %]
> <script>
> window.addEventListener('pageshow', function( e ){
>-    $('.form-control').prop('disabled' , false );
>+    $('.form-control:visible').prop('disabled' , false );
> });
> $(document).ready(function() {
>     [% IF search_groups %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34857: 158598 | 158619 | 158621