Attachment 158623 Details for Bug 35280 – Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form

[patch] Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form

Bug-35280-Fix-patron-attributes-clear-link-in-OPAC.patch (text/plain), 2.14 KB, created by Katrin Fischer on 2023-11-07 21:25:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-11-07 21:25:30 UTC

Size: 2.14 KB

patch

obsolete

>From 78c3c77cbbc99dbbf5a81b2073fee47e75fb13c5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 7 Nov 2023 17:07:17 +0000
>Subject: [PATCH] Bug 35280: Fix patron attributes "clear" link in OPAC patron
> entry form
>
>This patch makes a minor correction to the JavaScript controlling the
>behavior of the "clear" link which appears on the patron entry form next
>to patron attribute <select>s or <textarea>s which are editable in the
>OPAC.
>
>To test, apply the patch and create patron attributes
>which have both "Display in OPAC" and "Editable in OPAC" checked.
>
>- Create one which is tied to an authorized value, and one which isn't.
>- Log in to the OPAC and click the "Personal details" tab.
>- In the entry form, find the patron attribute fields under the
>  Additional information" heading..
>- Select a value in the dropdown, and enter text in the textarea.
>- Confirm that clicking the corresponding "Clear" link for each works as
>  expected.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt   | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index fd9587ce3d..02c81192a7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -1199,12 +1199,11 @@
>                 [% END %]
>             [% END %]
> 
>-            $(".patron-attributes").on( 'click', '.clear-attribute', function() {
>+            $(".patron-attributes").on( 'click', '.clear-attribute', function(e) {
>+                e.preventDefault();
>                 $(this).parent()
>-                    .find('textarea').attr('value', '').end()
>-                    .find('select').attr('value', '').end();
>-
>-                return false;
>+                    .find('textarea').val("").end()
>+                    .find('select').val("").end();
>             } );
> 
>             $(".patron-attributes").on( 'click', '.clone-attribute', function() {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35280: 158609 | 158618 | 158623