Attachment 158669 Details for Bug 23798 – Bug 23798: Atomic update fixes

[patch] Bug 23798: Atomic update fixes

Bug-23798-Atomic-update-fixes.patch (text/plain), 1.58 KB, created by Tomás Cohen Arazi (tcohen) on 2023-11-08 17:55:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-11-08 17:55:19 UTC

Size: 1.58 KB

patch

obsolete

>From 40391a85952ab8d9ea5a412cd1b879542eb4c3ff Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 8 Nov 2023 14:53:11 -0300
>Subject: [PATCH] Bug 23798: Atomic update fixes
>
>This patch makes the atomic update remove the syspref even if it wasn't
>previously set. It also tweaks the printed information to comform with
>current practices.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> ...-OpacMaintenanceNotice-to-additional-contents.pl | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug-23798-move-OpacMaintenanceNotice-to-additional-contents.pl b/installer/data/mysql/atomicupdate/bug-23798-move-OpacMaintenanceNotice-to-additional-contents.pl
>index d964eba681d..ed484fca24a 100755
>--- a/installer/data/mysql/atomicupdate/bug-23798-move-OpacMaintenanceNotice-to-additional-contents.pl
>+++ b/installer/data/mysql/atomicupdate/bug-23798-move-OpacMaintenanceNotice-to-additional-contents.pl
>@@ -30,9 +30,12 @@ return {
>                 undef, $insert_id, $opacmaintenancenotice
>             );
> 
>-            # Remove old system preference
>-            $dbh->do("DELETE FROM systempreferences WHERE variable='OpacMaintenanceNotice'");
>-            say $out "Bug 23798 update done";
>+            say $out "Added 'OpacMaintenanceNotice' additional content";
>         }
>-    }
>-    }
>+
>+        # Remove old system preference
>+        $dbh->do("DELETE FROM systempreferences WHERE variable='OpacMaintenanceNotice'");
>+        say $out "Removed system preference 'OpacMaintenanceNotice'";
>+
>+    },
>+};
>-- 
>2.42.1

Actions: View | Diff | Splinter Review

Attachments on bug 23798: 157205 | 157472 | 157584 | 157822 | 157905 | 157906 | 158308 | 158309 | 158667 | 158669