Bugzilla – Attachment 158709 Details for
Bug 35194
Javascript error: Uncaught TypeError: $(...).sortable is not a function
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35194: Remove obsoleted sortable function
Bug-35194-Remove-obsoleted-sortable-function.patch (text/plain), 2.72 KB, created by
Marcel de Rooy
on 2023-11-09 10:38:15 UTC
(
hide
)
Description:
Bug 35194: Remove obsoleted sortable function
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-11-09 10:38:15 UTC
Size:
2.72 KB
patch
obsolete
>From 5ec4d21e47440044d00e3d0fad41b1ad9651799f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 9 Nov 2023 10:35:06 +0000 >Subject: [PATCH] Bug 35194: Remove obsoleted sortable function >Content-Type: text/plain; charset=utf-8 > >Removes two occurrences and a commented one. > >Test plan: >[1] Go to cataloguing editor. Open dev console. Clone 500. >[2] Go to Admin/Did you mean. Try to toggle options. > >With this patch it works. Without this patch, JS errors. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt | 1 - > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 -- > koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js | 1 - > 3 files changed, 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >index 3e3b66ebde..41b0ecccb0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >@@ -93,7 +93,6 @@ > [% Asset.js("js/admin-menu.js") | $raw %] > <script> > $(document).ready(function() { >- $( ".pluginlist" ).sortable(); > $( ".plugin" ).addClass( "ui-widget ui-widget-content ui-helper-clearfix ui-corner-all" ) > .find( ".pluginname" ) > .addClass( "ui-widget-header ui-corner-all" ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index 8808df2c71..f257b19666 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -324,8 +324,6 @@ function CloneField(index, hideMarc, advancedMARCEditor) { > // insert this line on the page > original.parentNode.insertBefore(clone,original.nextSibling); > >- $("ul.sortable_subfield", clone).sortable(); >- > Select2Utils.initSelect2($(original).find('select')); > Select2Utils.initSelect2($(clone).find('select')); > } >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js b/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js >index 710652f87c..f6c12f8138 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/stockrotation.js >@@ -59,7 +59,6 @@ $(document).ready(function() { > $('#ajax_saving_icon').hide(); > $('#ajax_failed_icon').show(); > $('#ajax_failed_msg').show(); >- // $('#sortable_stages').sortable('cancel'); > }) > .always(function() { > sortable_stages.option("disabled", false ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35194
:
158709
|
158714
|
158746