Attachment 158760 Details for Bug 33164 – Bug 33164: Ensure return claim message shows if lost item return blocked

[patch] Bug 33164: Ensure return claim message shows if lost item return blocked

Bug-33164-Ensure-return-claim-message-shows-if-los.patch (text/plain), 1.62 KB, created by Emily Lamancusa (emlam) on 2023-11-09 18:15:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2023-11-09 18:15:40 UTC

Size: 1.62 KB

patch

obsolete

>From 2a315f39da2cd539d3e7ee922b7a5c884dcd84ed Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Wed, 8 Mar 2023 11:07:04 +1300
>Subject: [PATCH] Bug 33164: Ensure return claim message shows if lost item
> return blocked
>
>This fix ensures that a return claim confirmation always shows, even if
>the return of lost items has been blocked by BlockReturnOfLostItems
>being enabled.
>
>To test:
>
>1. Set BlockReturnOfLostItems system preference to Block
>2. Check out an item to a patron
>3. Go to the patrons page and claim a return on the item
>4. Check in the item and keep checking in the item. Notice the message
>"Item is lost, cannot be checked in." shows every time, but the return
>claim message only shows sometimes.
>
>5. Apply the patch and restart services
>
>6. Check in the item and keep checking in the item. Confirm both the
>lost message shows and the return claim message shows every time.
>7. Confirm the return of the item is still blocked.
>
>Sponsored-by: Pymble Ladies' College
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> circ/returns.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 564e60c966..1ab7015453 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -673,7 +673,6 @@ foreach my $code ( keys %$messages ) {
>     }
>     elsif ( $code eq 'WasLost' ) {
>         $err{waslost} = 1;
>-        $exit_required_p = 1 if C4::Context->preference("BlockReturnOfLostItems");
>     }
>     elsif ( $code eq 'LostItemFeeRefunded' ) {
>         $template->param( LostItemFeeRefunded => 1 );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33164: 147890 | 157710 | 157993 | 157994 | 158760 | 158761