Bugzilla – Attachment 158800 Details for
Bug 35310
Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35310: Only show 'Current renewals' link if item is currently checked out
Bug-35310-Only-show-Current-renewals-link-if-item-.patch (text/plain), 1.82 KB, created by
Pedro Amorim
on 2023-11-10 11:10:05 UTC
(
hide
)
Description:
Bug 35310: Only show 'Current renewals' link if item is currently checked out
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-11-10 11:10:05 UTC
Size:
1.82 KB
patch
obsolete
>From 2e5ff7b625a88d29233ddee7ea2ac6054e26c526 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 10 Nov 2023 11:01:58 +0000 >Subject: [PATCH] Bug 35310: Only show 'Current renewals' link if item is > currently checked out > >1) Checkout an item to Koha user, barcode 39999000003192 >2) Renew that barcode >3) Visit the items page of the biblio record, click on "View" in front of "Current renewals" >/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 >4) Notice it shows the renewals as expected >5) Return the same item 39999000003192 >6) Repeat 3). Notice it never loads renewals and network console shows HTTP error 400 >7) Apply this patch. Repeat the test plan. Notice the 'Current renewals' no longer shows for the item because it is no longer checked out, so whatever past renewals are no longer 'current' >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index f96a1f9e9f..63682de50b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -193,7 +193,7 @@ > [% END %] > [% END %] > </li> >- [% IF ITEM_DAT.renewals %] >+ [% IF ITEM_DAT.renewals && ITEM_DAT.object.checkout %] > <li> > <span class="label">Current renewals:</span> > [% ITEM_DAT.renewals | html %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35310
:
158799
|
158800
|
158801
|
158822
|
158823
|
158824
|
158976
|
159723
|
159724
|
159725