Attachment 158803 Details for Bug 35188 – Bug 35188: [23.05.x] Show checkout override for all noissues statuses

[patch] Bug 35188: [23.05.x] Show checkout override for all noissues statuses

Bug-35188-2305x-Show-checkout-override-for-all-noi.patch (text/plain), 2.99 KB, created by Nick Clemens (kidclamp) on 2023-11-10 11:57:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-11-10 11:57:47 UTC

Size: 2.99 KB

patch

obsolete

>From 7d4453e3b558c0ea0f0f8af64e04a8d13283eb3c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 30 Oct 2023 12:47:31 +0000
>Subject: [PATCH] Bug 35188: [23.05.x] Show checkout override for all noissues
> statuses
>
>This patch moves the override button up one level into the list of noissues in order to allow
>overriding any blocking status
>
>To test:
>1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too)
>2 - Mark a patron as expired, lost card, gone no address
>3 - Go to 'Check out' page for the patorn
>4 - Note you cannot override the restrictions
>5 - Add a manual restriction/debarment
>6 - Go to checkout again, now you can override
>7 - Remove the debarment
>8 - Add manually ot URL of checkout page '&foreallow=1'
>9 - Note you can now override the other restrictions
>10 - Apply patch
>11 - Reload patron
>12 - Note you now see the override button on the check out screen
>13 - Add a debarment
>14 - Confirm the button is still there
>15 - Confirm overriding allows the checkout (with or without a debarment)
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../prog/en/includes/patron_messages.inc | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>index 61d4053279c..2a4163330a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>@@ -74,12 +74,6 @@
> 
> [% END %]
> <a class="btn btn-xs btn-default" href="#reldebarments-tab" onclick="$('#reldebarments-tab').click()"> View restrictions</a>
>-
>- [% IF (noissues && CAN_user_circulate_force_checkout) %]
>- 
>- <a href="/cgi-bin/koha/circ/circulation.pl?forceallow=1&amp;borrowernumber=[% patron.borrowernumber | uri %]" class="btn btn-xs btn-default">Override restriction temporarily</a>
>- 
>- [% END %]
> </li> 
> [% END # /IF userdebarred %]
> 
>@@ -126,7 +120,13 @@
> Credits: Patron has a credit[% IF ( creditsamount ) %] of [% creditsamount | $Price %][% END %]
> </li>
> [% END %]
>-
>+ [% IF (noissues && CAN_user_circulate_force_checkout) %]
>+ <li>
>+ 
>+ <a href="/cgi-bin/koha/circ/circulation.pl?forceallow=1&amp;borrowernumber=[% patron.borrowernumber | uri %]" class="btn btn-xs btn-default">Override restriction temporarily</a>
>+ 
>+ </li>
>+ [% END %]
> </ul>
> 
> [% END # /F ( has_modifications || warndeparture... %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35188: 158062 | 158271 | 158413 | 158803