Bugzilla – Attachment 158813 Details for
Bug 35187
Fix line breaks in some HTML notices, including WELCOME
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[23.05] Bug 35187: Fix missing line breaks in WELCOME notice
2305-Bug-35187-Fix-missing-line-breaks-in-WELCOME-.patch (text/plain), 2.51 KB, created by
Katrin Fischer
on 2023-11-10 18:29:05 UTC
(
hide
)
Description:
[23.05] Bug 35187: Fix missing line breaks in WELCOME notice
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-11-10 18:29:05 UTC
Size:
2.51 KB
patch
obsolete
>From 4638e0770cff66aa5a3d4748373d72127bf5f07b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 10 Nov 2023 18:24:15 +0000 >Subject: [PATCH] [23.05] Bug 35187: Fix missing line breaks in WELCOME notice > >When a notices is marked as HTML, we need to use block elements >(p, div, li, etc.) or explicit line breaks. >This adds the line breaks where required. > >To test: > >WELCOME >* Without patch >* Make sure your Koha can send email (set up SMTP server, KohaAdminLibraryAddress) >* Make sure your patron has an email set >* In patron account, use "More > Welcome email" >* Verify all text is on one line >* Apply patch >* reset_all to install new sample notice templates >* Repeat test, verify welcome notice is now nice >--- > .../data/mysql/en/mandatory/sample_notices.yml | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml >index c5bc060873..500d379f18 100644 >--- a/installer/data/mysql/en/mandatory/sample_notices.yml >+++ b/installer/data/mysql/en/mandatory/sample_notices.yml >@@ -1418,15 +1418,15 @@ tables: > lang: default > content: > - "[% USE Koha %]" >- - "Hello [% borrower.title %] [% borrower.firstname %] [% borrower.surname %]." >- - "" >- - "Thank you for joining [% IF Koha.Preference('LibraryName') %][% Koha.Preference('LibraryName') %][% ELSE %]the library[% END %]" >- - "" >- - "You can search for all our materials in our <a href='[% Koha.Preference('OPACBaseURL') %]'>catalog</a>." >- - "" >- - "Your library card number is [% borrower.cardnumber %]" >- - "" >- - "If you have any problems or questions regarding your account, please contact the library." >+ - "Hello [% borrower.title %] [% borrower.firstname %] [% borrower.surname %].<br>" >+ - "<br>" >+ - "Thank you for joining [% IF Koha.Preference('LibraryName') %][% Koha.Preference('LibraryName') %][% ELSE %]the library[% END %]<br>" >+ - "<br>" >+ - "You can search for all our materials in our <a href='[% Koha.Preference('OPACBaseURL') %]'>catalog</a>.<br>" >+ - "<br>" >+ - "Your library card number is [% borrower.cardnumber %]<br>" >+ - "<br>" >+ - "If you have any problems or questions regarding your account, please contact the library." > > - module: members > code: 2FA_OTP_TOKEN >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35187
:
158049
|
158050
|
158055
|
158509
|
158510
| 158813 |
158833